Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Issue 2133873003: Handle SDK extensions in the SDK (Closed)

Created:
4 years, 5 months ago by Brian Wilkerson
Modified:
4 years, 5 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org, pquitslund
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+251 lines, -56 lines) Patch
M pkg/analyzer/lib/source/sdk_ext.dart View 2 chunks +18 lines, -3 lines 0 comments Download
M pkg/analyzer/lib/src/context/builder.dart View 2 chunks +30 lines, -1 line 0 comments Download
M pkg/analyzer/lib/src/generated/sdk_io.dart View 1 chunk +14 lines, -0 lines 0 comments Download
M pkg/analyzer/test/src/context/builder_test.dart View 14 chunks +189 lines, -52 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Brian Wilkerson
I haven't yet updated server or cli to take advantage of the new support, that ...
4 years, 5 months ago (2016-07-08 22:03:13 UTC) #2
scheglov
LGTM
4 years, 5 months ago (2016-07-08 22:08:26 UTC) #3
Brian Wilkerson
4 years, 5 months ago (2016-07-11 14:44:15 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
2eae1b611c49e288adca4cd168c602d9c6a526cf (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698