Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1082)

Issue 2133873002: [GN docs] Add missing word in gn actions help string (Closed)

Created:
4 years, 5 months ago by Devlin
Modified:
4 years, 5 months ago
Reviewers:
Dirk Pranke, brettw
CC:
chromium-reviews, Dirk Pranke, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[GN docs] Add missing word in gn actions help string gn actions help said "run a script a single time to produce or more output files". Add the missing "one" to make this "one or more output files". BUG=None Committed: https://crrev.com/bf462ea0de8604630aecc49e976c3bd9d646a4a0 Cr-Commit-Position: refs/heads/master@{#404533}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M tools/gn/docs/reference.md View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/gn/functions_target.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
Devlin
Random cleanup that was bothering me. :)
4 years, 5 months ago (2016-07-08 20:46:42 UTC) #2
Dirk Pranke
lgtm, thanks!
4 years, 5 months ago (2016-07-08 21:07:39 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2133873002/1
4 years, 5 months ago (2016-07-08 21:10:09 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-08 23:29:50 UTC) #7
commit-bot: I haz the power
4 years, 5 months ago (2016-07-08 23:32:57 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bf462ea0de8604630aecc49e976c3bd9d646a4a0
Cr-Commit-Position: refs/heads/master@{#404533}

Powered by Google App Engine
This is Rietveld 408576698