Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1683)

Issue 213383007: Revert of Move GetCursor() method from WindowDelegate to its own delegate interface CursorDelegate. (Closed)

Created:
6 years, 9 months ago by Ben Goodger (Google)
Modified:
6 years, 9 months ago
Reviewers:
sky
CC:
chromium-reviews, sadrul, yusukes+watch_chromium.org, viettrungluu+watch_chromium.org, dcheng, sievers+watch_chromium.org, yukishiino+watch_chromium.org, ben+aura_chromium.org, ben+mojo_chromium.org, miu+watch_chromium.org, jbauman+watch_chromium.org, jam, abarth-chromium, joi+watch-content_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, kalyank, penghuang+watch_chromium.org, piman+watch_chromium.org, ben+views_chromium.org, darin (slow to review), tfarina, Aaron Boodman, danakj+watch_chromium.org, James Su, ben+ash_chromium.org
Visibility:
Public.

Description

Revert of Move GetCursor() method from WindowDelegate to its own delegate interface CursorDelegate. (https://codereview.chromium.org/211733003/) Reason for revert: http://crbug.com/357015 Original issue's description: > Move GetCursor() method from WindowDelegate to its own delegate interface CursorDelegate. > > R=sky@chromium.org > http://crbug.com/308845 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=259631 TBR=sky@chromium.org NOTREECHECKS=true NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=259805

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -116 lines) Patch
M ash/display/cursor_window_controller.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M ash/drag_drop/drag_drop_controller.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M ash/root_window_controller.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura.h View 4 chunks +1 line, -5 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura.cc View 2 chunks +6 lines, -10 lines 0 comments Download
M content/browser/web_contents/aura/image_window_delegate.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/web_contents/aura/image_window_delegate.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M content/browser/web_contents/web_contents_view_aura.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/web_contents/web_contents_view_aura.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M content/content_browser.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M mojo/examples/aura_demo/aura_demo.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M ui/aura/demo/demo_main.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M ui/aura/test/test_window_delegate.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/aura/test/test_window_delegate.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M ui/aura/window.h View 1 chunk +3 lines, -0 lines 0 comments Download
M ui/aura/window.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M ui/aura/window_delegate.h View 1 chunk +4 lines, -0 lines 0 comments Download
M ui/keyboard/keyboard_controller.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M ui/views/controls/native/native_view_host_aura.cc View 2 chunks +2 lines, -6 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_native_widget_aura.h View 4 chunks +2 lines, -6 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_native_widget_aura.cc View 3 chunks +4 lines, -9 lines 0 comments Download
M ui/views/widget/native_widget_aura.h View 4 chunks +2 lines, -6 lines 0 comments Download
M ui/views/widget/native_widget_aura.cc View 3 chunks +4 lines, -8 lines 0 comments Download
M ui/wm/core/compound_event_filter.cc View 2 chunks +1 line, -4 lines 0 comments Download
D ui/wm/public/cursor_delegate.h View 1 chunk +0 lines, -35 lines 0 comments Download
D ui/wm/public/cursor_delegate.cc View 1 chunk +0 lines, -24 lines 0 comments Download
M ui/wm/wm.gyp View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Ben Goodger (Google)
Created Revert of Move GetCursor() method from WindowDelegate to its own delegate interface CursorDelegate.
6 years, 9 months ago (2014-03-27 06:05:26 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ben@chromium.org/213383007/1
6 years, 9 months ago (2014-03-27 06:05:40 UTC) #2
commit-bot: I haz the power
6 years, 9 months ago (2014-03-27 06:07:06 UTC) #3
Message was sent while issue was closed.
Change committed as 259805

Powered by Google App Engine
This is Rietveld 408576698