Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(367)

Issue 2133823002: Improve hot reload test mode (Closed)

Created:
4 years, 5 months ago by Cutch
Modified:
4 years, 5 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Improve hot reload test mode - [x] Start reloading even earlier. - [x] Keep the value of FLAG_reload_every per-isolate (so spawned isolates reload eagerly too). - [x] Adjust the reload every back off curve to be linear in the beginning. - [x] Cap the reload every threshold at 1,000,000 - [x] Test status file updates. - [x] Stop disabling the background compiler / OSR when running tests. - [x] Skip multi tests with compilation errors when reloading. BUG= R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/ef71bc1834d1594349c34401b5a97fe071139bef

Patch Set 1 #

Total comments: 2

Patch Set 2 : rmacnak review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -36 lines) Patch
M runtime/bin/main.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/vm/code_generator.cc View 3 chunks +9 lines, -7 lines 0 comments Download
M runtime/vm/flow_graph_compiler.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/isolate.h View 2 chunks +8 lines, -0 lines 0 comments Download
M runtime/vm/isolate.cc View 3 chunks +22 lines, -1 line 0 comments Download
M tests/corelib/corelib.status View 1 chunk +0 lines, -12 lines 0 comments Download
M tests/lib/lib.status View 1 chunk +1 line, -0 lines 0 comments Download
M tests/standalone/standalone.status View 1 chunk +2 lines, -6 lines 0 comments Download
M tools/testing/dart/compiler_configuration.dart View 1 chunk +0 lines, -4 lines 0 comments Download
M tools/testing/dart/multitest.dart View 1 2 chunks +12 lines, -1 line 0 comments Download
M tools/testing/dart/test_suite.dart View 1 2 chunks +7 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Cutch
4 years, 5 months ago (2016-07-08 17:51:15 UTC) #3
rmacnak
lgtm https://chromiumcodereview.appspot.com/2133823002/diff/1/tools/testing/dart/multitest.dart File tools/testing/dart/multitest.dart (right): https://chromiumcodereview.appspot.com/2133823002/diff/1/tools/testing/dart/multitest.dart#newcode282 tools/testing/dart/multitest.dart:282: // Skip multi tests with compilation errors when ...
4 years, 5 months ago (2016-07-11 19:18:22 UTC) #4
Cutch
Committed patchset #2 (id:20001) manually as ef71bc1834d1594349c34401b5a97fe071139bef (presubmit successful).
4 years, 5 months ago (2016-07-11 19:29:21 UTC) #6
Cutch
4 years, 5 months ago (2016-07-11 19:29:55 UTC) #7
Message was sent while issue was closed.
https://chromiumcodereview.appspot.com/2133823002/diff/1/tools/testing/dart/m...
File tools/testing/dart/multitest.dart (right):

https://chromiumcodereview.appspot.com/2133823002/diff/1/tools/testing/dart/m...
tools/testing/dart/multitest.dart:282: // Skip multi tests with compilation
errors when hot reloading.
On 2016/07/11 19:18:22, rmacnak wrote:
> // Running a test that expects a compilation error with hot reloading is
> redundant with a regular run of the test.

Done.

Powered by Google App Engine
This is Rietveld 408576698