Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(327)

Unified Diff: content/browser/browser_main_loop.cc

Issue 2133813002: Check that all RenderProcessHost(s) are terminated. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/browser/renderer_host/render_process_host_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/browser_main_loop.cc
diff --git a/content/browser/browser_main_loop.cc b/content/browser/browser_main_loop.cc
index 99d9a89d9d0b3fd6cae4b2f8db519912c9d9e145..943b2be735f60677e9dcc3396db5e2c6aa158958 100644
--- a/content/browser/browser_main_loop.cc
+++ b/content/browser/browser_main_loop.cc
@@ -1084,6 +1084,11 @@ void BrowserMainLoop::ShutdownThreadsAndCleanUp() {
}
case BrowserThread::IO: {
TRACE_EVENT0("shutdown", "BrowserMainLoop::Subsystem:IOThread");
+ // IO thread is about to be destoyed.
+ // All IO-thread resources held by RenderProcessHost(s) must have been
+ // released by now, which happens when IPC channel to the renderer
+ // process is destoyed.
+ CHECK(!RenderProcessHostImpl::HasAnyConnection());
alokp 2016/07/08 17:30:15 jam@: Is this a valid assumption? We are hitting
ResetThread_IO(std::move(io_thread_));
break;
}
« no previous file with comments | « no previous file | content/browser/renderer_host/render_process_host_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698