Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Side by Side Diff: content/browser/browser_main_loop.cc

Issue 2133813002: Check that all RenderProcessHost(s) are terminated. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: added more specific checks Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | content/browser/renderer_host/render_process_host_impl.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/browser/browser_main_loop.h" 5 #include "content/browser/browser_main_loop.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 8
9 #include <string> 9 #include <string>
10 #include <utility> 10 #include <utility>
(...skipping 1061 matching lines...) Expand 10 before | Expand all | Expand 10 after
1072 ResetThread_PROCESS_LAUNCHER(std::move(process_launcher_thread_)); 1072 ResetThread_PROCESS_LAUNCHER(std::move(process_launcher_thread_));
1073 break; 1073 break;
1074 } 1074 }
1075 case BrowserThread::CACHE: { 1075 case BrowserThread::CACHE: {
1076 TRACE_EVENT0("shutdown", "BrowserMainLoop::Subsystem:CacheThread"); 1076 TRACE_EVENT0("shutdown", "BrowserMainLoop::Subsystem:CacheThread");
1077 ResetThread_CACHE(std::move(cache_thread_)); 1077 ResetThread_CACHE(std::move(cache_thread_));
1078 break; 1078 break;
1079 } 1079 }
1080 case BrowserThread::IO: { 1080 case BrowserThread::IO: {
1081 TRACE_EVENT0("shutdown", "BrowserMainLoop::Subsystem:IOThread"); 1081 TRACE_EVENT0("shutdown", "BrowserMainLoop::Subsystem:IOThread");
1082 // At this point we should have removed all tabs which will lead to all
1083 // RenderProcessHostImpl instances getting terminated.
1084 // It is suspected that this is not happening: crbug.com/608049.
1085 // TODO(alokp): Remove this after fixing the issue.
1086 RenderProcessHostImpl::CheckAllTerminated();
1082 ResetThread_IO(std::move(io_thread_)); 1087 ResetThread_IO(std::move(io_thread_));
1083 break; 1088 break;
1084 } 1089 }
1085 case BrowserThread::UI: 1090 case BrowserThread::UI:
1086 case BrowserThread::ID_COUNT: 1091 case BrowserThread::ID_COUNT:
1087 default: 1092 default:
1088 NOTREACHED(); 1093 NOTREACHED();
1089 break; 1094 break;
1090 } 1095 }
1091 } 1096 }
(...skipping 415 matching lines...) Expand 10 before | Expand all | Expand 10 after
1507 scoped_refptr<base::SingleThreadTaskRunner> worker_task_runner = 1512 scoped_refptr<base::SingleThreadTaskRunner> worker_task_runner =
1508 audio_thread_->task_runner(); 1513 audio_thread_->task_runner();
1509 audio_manager_ = media::AudioManager::Create(std::move(audio_task_runner), 1514 audio_manager_ = media::AudioManager::Create(std::move(audio_task_runner),
1510 std::move(worker_task_runner), 1515 std::move(worker_task_runner),
1511 MediaInternals::GetInstance()); 1516 MediaInternals::GetInstance());
1512 } 1517 }
1513 CHECK(audio_manager_); 1518 CHECK(audio_manager_);
1514 } 1519 }
1515 1520
1516 } // namespace content 1521 } // namespace content
OLDNEW
« no previous file with comments | « no previous file | content/browser/renderer_host/render_process_host_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698