Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Side by Side Diff: content/browser/browser_main_loop.cc

Issue 2133813002: Check that all RenderProcessHost(s) are terminated. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | content/browser/renderer_host/render_process_host_impl.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/browser/browser_main_loop.h" 5 #include "content/browser/browser_main_loop.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 8
9 #include <string> 9 #include <string>
10 #include <utility> 10 #include <utility>
(...skipping 1066 matching lines...) Expand 10 before | Expand all | Expand 10 after
1077 ResetThread_PROCESS_LAUNCHER(std::move(process_launcher_thread_)); 1077 ResetThread_PROCESS_LAUNCHER(std::move(process_launcher_thread_));
1078 break; 1078 break;
1079 } 1079 }
1080 case BrowserThread::CACHE: { 1080 case BrowserThread::CACHE: {
1081 TRACE_EVENT0("shutdown", "BrowserMainLoop::Subsystem:CacheThread"); 1081 TRACE_EVENT0("shutdown", "BrowserMainLoop::Subsystem:CacheThread");
1082 ResetThread_CACHE(std::move(cache_thread_)); 1082 ResetThread_CACHE(std::move(cache_thread_));
1083 break; 1083 break;
1084 } 1084 }
1085 case BrowserThread::IO: { 1085 case BrowserThread::IO: {
1086 TRACE_EVENT0("shutdown", "BrowserMainLoop::Subsystem:IOThread"); 1086 TRACE_EVENT0("shutdown", "BrowserMainLoop::Subsystem:IOThread");
1087 // IO thread is about to be destoyed.
1088 // All IO-thread resources held by RenderProcessHost(s) must have been
1089 // released by now, which happens when IPC channel to the renderer
1090 // process is destoyed.
1091 CHECK(!RenderProcessHostImpl::HasAnyConnection());
alokp 2016/07/08 17:30:15 jam@: Is this a valid assumption? We are hitting
1087 ResetThread_IO(std::move(io_thread_)); 1092 ResetThread_IO(std::move(io_thread_));
1088 break; 1093 break;
1089 } 1094 }
1090 case BrowserThread::UI: 1095 case BrowserThread::UI:
1091 case BrowserThread::ID_COUNT: 1096 case BrowserThread::ID_COUNT:
1092 default: 1097 default:
1093 NOTREACHED(); 1098 NOTREACHED();
1094 break; 1099 break;
1095 } 1100 }
1096 } 1101 }
(...skipping 417 matching lines...) Expand 10 before | Expand all | Expand 10 after
1514 scoped_refptr<base::SingleThreadTaskRunner> worker_task_runner = 1519 scoped_refptr<base::SingleThreadTaskRunner> worker_task_runner =
1515 audio_thread_->task_runner(); 1520 audio_thread_->task_runner();
1516 audio_manager_ = media::AudioManager::Create(std::move(audio_task_runner), 1521 audio_manager_ = media::AudioManager::Create(std::move(audio_task_runner),
1517 std::move(worker_task_runner), 1522 std::move(worker_task_runner),
1518 MediaInternals::GetInstance()); 1523 MediaInternals::GetInstance());
1519 } 1524 }
1520 CHECK(audio_manager_); 1525 CHECK(audio_manager_);
1521 } 1526 }
1522 1527
1523 } // namespace content 1528 } // namespace content
OLDNEW
« no previous file with comments | « no previous file | content/browser/renderer_host/render_process_host_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698