Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 2133803004: Fix MultibufferDataSource::GetSize (Closed)

Created:
4 years, 5 months ago by hubbe
Modified:
4 years, 5 months ago
Reviewers:
DaleCurtis
CC:
chromium-reviews, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix MultibufferDataSource::GetSize When file loading is finished ResourceMultiBufferDataProvider count DataBuffer queue size twice, so GetSize returned incorrect value. BUG=625515, 627525, 624853 patch from issue 2110853006 at patchset 1 (http://crrev.com/2110853006#ps1) Committed: https://crrev.com/6e50a4b489e2c06e368ee239911e8191b1a507e9 Cr-Commit-Position: refs/heads/master@{#405242}

Patch Set 1 #

Patch Set 2 : bugfix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -4 lines) Patch
M media/blink/multibuffer_data_source_unittest.cc View 2 chunks +23 lines, -0 lines 0 comments Download
M media/blink/resource_multibuffer_data_provider.h View 1 chunk +3 lines, -0 lines 0 comments Download
M media/blink/resource_multibuffer_data_provider.cc View 1 3 chunks +10 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
hubbe
4 years, 5 months ago (2016-07-13 07:44:49 UTC) #3
DaleCurtis
lgtm
4 years, 5 months ago (2016-07-13 16:46:53 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2133803004/20001
4 years, 5 months ago (2016-07-13 17:33:14 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-13 19:55:22 UTC) #8
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-13 19:56:03 UTC) #9
commit-bot: I haz the power
4 years, 5 months ago (2016-07-13 19:57:51 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/6e50a4b489e2c06e368ee239911e8191b1a507e9
Cr-Commit-Position: refs/heads/master@{#405242}

Powered by Google App Engine
This is Rietveld 408576698