Issue 2133803003: Don't paint the stolen background of the body even when it has display:table-cell.

Issue 2133803003: Don't paint the stolen background of the body even when it has display:table-cell. (Closed)

Created:
4 years, 5 months ago by chrishtr

Modified:
4 years, 5 months ago

Reviewers:
trchen

CC:
blink-reviews, blink-reviews-paint_chromium.org, chromium-reviews, dshwang, slimming-paint-reviews_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Don't paint the stolen background of the body even when it has display:table-cell. BUG=622795 Committed: https://crrev.com/4d17020d9c377daa8c119aa4648dcf37b2b94490 Cr-Commit-Position: refs/heads/master@{#404529}

Created: 4 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -0 lines)			Patch
A	third_party/WebKit/LayoutTests/paint/background/body-background-when-table-cell.html	View	1	1 chunk	+6 lines, -0 lines	0 comments	Download
A	third_party/WebKit/LayoutTests/paint/background/body-background-when-table-cell-expected.html	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	third_party/WebKit/Source/core/paint/TableCellPainter.cpp	View		1 chunk	+3 lines, -0 lines	0 comments	Download

Total messages: 10 (4 generated)

chrishtr

There is already code in BoxPainter to avoid painting the background in such situations. Omitting ...

4 years, 5 months ago (2016-07-08 19:56:13 UTC) #3

trchen

lgtm. Yea... The used value of background should have been resolved to none at StyleResolver ...

4 years, 5 months ago (2016-07-08 23:13:09 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2133803003/20001

4 years, 5 months ago (2016-07-08 23:15:03 UTC) #6

commit-bot: I haz the power

4 years, 5 months ago (2016-07-08 23:23:56 UTC) #10

Message was sent while issue was closed.

Patchset 2 (id:??) landed as
https://crrev.com/4d17020d9c377daa8c119aa4648dcf37b2b94490
Cr-Commit-Position: refs/heads/master@{#404529}