Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1853)

Unified Diff: chrome/browser/resources/settings/bluetooth_page/bluetooth_device_list_item.html

Issue 2133793003: Unify iron-dropdown CSS (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: . Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/bluetooth_page/bluetooth_device_list_item.html
diff --git a/chrome/browser/resources/settings/bluetooth_page/bluetooth_device_list_item.html b/chrome/browser/resources/settings/bluetooth_page/bluetooth_device_list_item.html
index 500c5f9b411764152e7b1d9d9471a0b65a348a96..42ddd664ee2f82930b4a43cd6a36bc1b76b4c90f 100644
--- a/chrome/browser/resources/settings/bluetooth_page/bluetooth_device_list_item.html
+++ b/chrome/browser/resources/settings/bluetooth_page/bluetooth_device_list_item.html
@@ -5,9 +5,10 @@
<link rel="import" href="chrome://resources/polymer/v1_0/iron-icon/iron-icon.html">
<link rel="import" href="chrome://resources/polymer/v1_0/paper-icon-button/paper-icon-button.html">
<link rel="import" href="chrome://resources/polymer/v1_0/paper-item/paper-item.html">
+<link rel="import" href="/settings_shared_css.html">
<dom-module id="bluetooth-device-list-item">
- <style>
+ <style include="settings-shared">
iron-icon {
-webkit-padding-start: 10px;
}
@@ -19,12 +20,6 @@
span.name[connected] {
font-weight: 500;
}
-
- /* TODO(dbeam): combine with other similar styles. */
- .dropdown-content {
- background: white;
- box-shadow: 0 2px 6px grey;
- }
</style>
<template>
<div class="flex layout horizontal center" dropdown$="[[dropdownOpened]]"
@@ -36,16 +31,11 @@
</iron-icon>
<span class="flex"></span>
<span hidden$="[[!device.connecting]]">$i18n{bluetoothConnecting}</span>
- <!-- This <div on-tap> is not [actionable] because its effect is not user
- visible. -->
Dan Beam 2016/07/08 23:08:08 why are you removing this?
stevenjb 2016/07/08 23:50:05 I looked through the code and found a number of di
Dan Beam 2016/07/09 00:09:59 which ones?
<div hidden$="[[!device.paired]]" on-tap="doNothing_">
<paper-icon-button icon="cr:more-vert" toggles
active="{{dropdownOpened}}">
</paper-icon-button>
- <!-- TODO(dbeam): does this need [actionable] if all the controls are
- paper-items. Conversely, should the on-tap be at this level? -->
- <iron-dropdown opened="{{dropdownOpened}}" on-tap="menuSelected_"
- actionable>
+ <iron-dropdown opened="{{dropdownOpened}}" on-tap="menuSelected_">
<div class="dropdown-content">
<paper-item id="connect" hidden$="[[device.connected]]">
$i18n{bluetoothConnect}

Powered by Google App Engine
This is Rietveld 408576698