gpu/command_buffer/service/texture_manager.cc - Issue 2133743003: Use Share Group rather than Client ID in GPU memory logs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gpu/command_buffer/service/texture_manager.cc

Issue 2133743003: Use Share Group rather than Client ID in GPU memory logs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « gpu/command_buffer/service/buffer_manager.cc ('k') | tools/perf/benchmarks/system_health_smoke_test.py » ('j') | tools/perf/benchmarks/system_health_smoke_test.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: gpu/command_buffer/service/texture_manager.cc

diff --git a/gpu/command_buffer/service/texture_manager.cc b/gpu/command_buffer/service/texture_manager.cc

index f6a75dd40e91325cd5bc88ee00c8f5b83fb822d3..8e5113147430394234166060b3dc777e8f9b5594 100644

--- a/gpu/command_buffer/service/texture_manager.cc

+++ b/gpu/command_buffer/service/texture_manager.cc

@@ -3068,9 +3068,9 @@ void TextureManager::DumpTextureRef(base::trace_event::ProcessMemoryDump* pmd,

if (size == 0)

return;

- std::string dump_name =

- base::StringPrintf("gpu/gl/textures/client_%d/texture_%d",

- memory_tracker_->ClientId(), ref->client_id());

+ std::string dump_name = base::StringPrintf(

+ "gpu/gl/textures/share_group_%" PRIu64 "/texture_%d",

+ memory_tracker_->ShareGroupTracingGUID(), ref->client_id());

base::trace_event::MemoryAllocatorDump* dump =

pmd->CreateAllocatorDump(dump_name);