Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Side by Side Diff: tools/perf/benchmarks/system_health_smoke_test.py

Issue 2133743003: Use Share Group rather than Client ID in GPU memory logs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add missing #include for windows Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « gpu/command_buffer/service/texture_manager.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2016 The Chromium Authors. All rights reserved. 1 # Copyright 2016 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 """Run all system health stories used by system health benchmarks. 5 """Run all system health stories used by system health benchmarks.
6 6
7 Only memory benchmarks are used when running these stories to make the total 7 Only memory benchmarks are used when running these stories to make the total
8 cycle time manageable. Other system health benchmarks should be using the same 8 cycle time manageable. Other system health benchmarks should be using the same
9 stories as memory ones, only with fewer actions (no memory dumping). 9 stories as memory ones, only with fewer actions (no memory dumping).
10 """ 10 """
(...skipping 23 matching lines...) Expand all
34 sh_benchmark_classes = discover.DiscoverClassesInModule( 34 sh_benchmark_classes = discover.DiscoverClassesInModule(
35 system_health, perf_benchmark.PerfBenchmark, 35 system_health, perf_benchmark.PerfBenchmark,
36 index_by_class_name=True).values() 36 index_by_class_name=True).values()
37 return list(b for b in sh_benchmark_classes if 37 return list(b for b in sh_benchmark_classes if
38 b.Name().startswith('system_health.memory')) 38 b.Name().startswith('system_health.memory'))
39 39
40 40
41 _DISABLED_TESTS = frozenset({ 41 _DISABLED_TESTS = frozenset({
42 # crbug.com/624474 42 # crbug.com/624474
43 'benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.system_hea lth.memory_desktop.load:tools:dropbox', # pylint: disable=line-too-long 43 'benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.system_hea lth.memory_desktop.load:tools:dropbox', # pylint: disable=line-too-long
44 # crbug.com/624701
45 'benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.system_hea lth.memory_mobile.load:games:bubbles', # pylint: disable=line-too-long
46 # crbug.com/624840
47 'benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.system_hea lth.memory_mobile.load:tools:drive', # pylint: disable=line-too-long
48 'benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.system_hea lth.memory_mobile.load:tools:gmail', # pylint: disable=line-too-long
49 'benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.system_hea lth.memory_mobile.load:tools:dropbox', # pylint: disable=line-too-long
50 }) 44 })
51 45
52 46
53 def _GenerateSmokeTestCase(benchmark_class, story_to_smoke_test): 47 def _GenerateSmokeTestCase(benchmark_class, story_to_smoke_test):
54 48
55 # NOTE TO SHERIFFS: DO NOT DISABLE THIS TEST. 49 # NOTE TO SHERIFFS: DO NOT DISABLE THIS TEST.
56 # 50 #
57 # This smoke test dynamically tests all system health user stories. So 51 # This smoke test dynamically tests all system health user stories. So
58 # disabling it for one failing or flaky benchmark would disable a much 52 # disabling it for one failing or flaky benchmark would disable a much
59 # wider swath of coverage than is usally intended. Instead, if a test is 53 # wider swath of coverage than is usally intended. Instead, if a test is
(...skipping 71 matching lines...) Expand 10 before | Expand all | Expand 10 after
131 # parsed during test time which happens after load_tests are called. 125 # parsed during test time which happens after load_tests are called.
132 # Since none of our system health benchmarks creates stories based on 126 # Since none of our system health benchmarks creates stories based on
133 # command line options, it should be ok to pass options=None to 127 # command line options, it should be ok to pass options=None to
134 # CreateStorySet. 128 # CreateStorySet.
135 for story_to_smoke_test in ( 129 for story_to_smoke_test in (
136 benchmark_class().CreateStorySet(options=None).stories): 130 benchmark_class().CreateStorySet(options=None).stories):
137 suite.addTest( 131 suite.addTest(
138 _GenerateSmokeTestCase(benchmark_class, story_to_smoke_test)) 132 _GenerateSmokeTestCase(benchmark_class, story_to_smoke_test))
139 133
140 return suite 134 return suite
OLDNEW
« no previous file with comments | « gpu/command_buffer/service/texture_manager.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698