Issue 2133733003: Specify the exact project to build

Issue 2133733003: Specify the exact project to build (Closed)

Created:
4 years, 5 months ago by Tyler Breisacher (Chromium)

Modified:
4 years, 5 months ago

Reviewers:
Dan Beam

CC:
chromium-reviews, vitalyp+closure_chromium.org, jlklein+watch-closure_chromium.org, dbeam+watch-closure_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Closure Compiler: When building the compiler jar with Maven, specify the exact project to build BUG= Committed: https://crrev.com/13f9b1037b5bc9683ee84ba75cd60c901f45c5d5 Cr-Commit-Position: refs/heads/master@{#404521}

Created: 4 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -2 lines)			Patch
	M	third_party/closure_compiler/roll_closure_compiler	View		1 chunk	+1 line, -2 lines	0 comments	Download

Total messages: 10 (5 generated)

Tyler Breisacher (Chromium)

This also looks like it might avoid a problem when https://github.com/google/closure-compiler/pull/1650

4 years, 5 months ago (2016-07-08 20:54:27 UTC) #2

Dan Beam

lgtm, but can you make the CL description less generic? this is going to be ...

4 years, 5 months ago (2016-07-08 21:33:37 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2133733003/1

4 years, 5 months ago (2016-07-08 22:15:23 UTC) #6

commit-bot: I haz the power

4 years, 5 months ago (2016-07-08 22:55:42 UTC) #10

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/13f9b1037b5bc9683ee84ba75cd60c901f45c5d5
Cr-Commit-Position: refs/heads/master@{#404521}