Fixes crash in AudioManagerMac at shutdown

Fixes crash in AudioManagerMac at shutdown.

Takes a copy of the list of input streams before deleting the stream.
The reason is that when a stream is deleted it also removes itself from the list and we are iterating over that same list. Should be resolved by taking a copy of the list first.

BUG=626512
Committed: https://crrev.com/fe1a694e498267bfa2597f5db820148f4eb38bd6
Cr-Commit-Position: refs/heads/master@{#404349}

[henrika (OOO until Aug 14), 2016-07-08 11:46:33]

Description was changed from

==========
Fixes crash in AudioManagerMac at shutdown

BUG=
==========

to

==========
Fixes crash in AudioManagerMac at shutdown

BUG=626512
==========

[henrika (OOO until Aug 14), 2016-07-08 11:46:33]

henrika@chromium.org changed reviewers:
+ tommi@chromium.org

[henrika (OOO until Aug 14), 2016-07-08 11:46:54]

PTAL

[henrika (OOO until Aug 14), 2016-07-08 11:48:47]

Description was changed from

==========
Fixes crash in AudioManagerMac at shutdown

BUG=626512
==========

to

==========
Fixes crash in AudioManagerMac at shutdown.

Takes a copy of the list of input streams before deleting the stream.
The reason is that when a stream is deleted it also removes itself from the list
and we are iterating over that same list. Should be resolved by taking a copy of
the list first.

BUG=626512
==========

[tommi (sloooow) - chröme, 2016-07-08 12:07:00]

lgtm

https://codereview.chromium.org/2133703002/diff/1/media/audio/mac/audio_manag...
File media/audio/mac/audio_manager_mac.cc (right):

https://codereview.chromium.org/2133703002/diff/1/media/audio/mac/audio_manag...
media/audio/mac/audio_manager_mac.cc:393: auto low_latency_input_streams_copy =
low_latency_input_streams_;
nit: add a comment above this line that explains why this is needed.  Something
like:

// |low_latency_input_streams_| will be modified during the call to
stream->Close(), so
// we can't iterate over it here.  Instead iterate over a copy.

[henrika (OOO until Aug 14), 2016-07-08 12:19:38]

Done. Landing.

https://codereview.chromium.org/2133703002/diff/1/media/audio/mac/audio_manag...
File media/audio/mac/audio_manager_mac.cc (right):

https://codereview.chromium.org/2133703002/diff/1/media/audio/mac/audio_manag...
media/audio/mac/audio_manager_mac.cc:393: auto low_latency_input_streams_copy =
low_latency_input_streams_;
Good idea, thanks!

[henrika (OOO until Aug 14), 2016-07-08 12:20:16]

The CQ bit was checked by henrika@chromium.org

[henrika (OOO until Aug 14), 2016-07-08 12:20:17]

The patchset sent to the CQ was uploaded after l-g-t-m from tommi@chromium.org
Link to the patchset: https://codereview.chromium.org/2133703002/#ps20001
(title: "Improved comment")

[commit-bot: I haz the power, 2016-07-08 12:20:38]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-08 14:05:06]

Description was changed from

==========
Fixes crash in AudioManagerMac at shutdown.

Takes a copy of the list of input streams before deleting the stream.
The reason is that when a stream is deleted it also removes itself from the list
and we are iterating over that same list. Should be resolved by taking a copy of
the list first.

BUG=626512
==========

to

==========
Fixes crash in AudioManagerMac at shutdown.

Takes a copy of the list of input streams before deleting the stream.
The reason is that when a stream is deleted it also removes itself from the list
and we are iterating over that same list. Should be resolved by taking a copy of
the list first.

BUG=626512
==========

[commit-bot: I haz the power, 2016-07-08 14:05:06]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-07-08 14:05:28]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-08 14:06:29]

Description was changed from

==========
Fixes crash in AudioManagerMac at shutdown.

Takes a copy of the list of input streams before deleting the stream.
The reason is that when a stream is deleted it also removes itself from the list
and we are iterating over that same list. Should be resolved by taking a copy of
the list first.

BUG=626512
==========

to

==========
Fixes crash in AudioManagerMac at shutdown.

Takes a copy of the list of input streams before deleting the stream.
The reason is that when a stream is deleted it also removes itself from the list
and we are iterating over that same list. Should be resolved by taking a copy of
the list first.

BUG=626512

Committed: https://crrev.com/fe1a694e498267bfa2597f5db820148f4eb38bd6
Cr-Commit-Position: refs/heads/master@{#404349}
==========

[commit-bot: I haz the power, 2016-07-08 14:06:30]

Patchset 2 (id:??) landed as
https://crrev.com/fe1a694e498267bfa2597f5db820148f4eb38bd6
Cr-Commit-Position: refs/heads/master@{#404349}