tools/turbolizer/code-view.js - Issue 2133663002: [turbolizer] Improve code comments in disassembly

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/turbolizer/code-view.js

Issue 2133663002: [turbolizer] Improve code comments in disassembly (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/turbolizer/code-view.js

diff --git a/tools/turbolizer/code-view.js b/tools/turbolizer/code-view.js

index aa106d3ab0f3412e64aded66db9156f61d62feeb..98554fdc016f1cb8fa243db91a7938537a187491 100644

--- a/tools/turbolizer/code-view.js

+++ b/tools/turbolizer/code-view.js

@@ -30,6 +30,7 @@ var CodeView = function(divID, PR, sourceText, sourcePosition, broker) {

for (var span of items) {

ranges.push([span.start, span.end, null]);

}

+ broker.clear(selectionHandler);

broker.select(selectionHandler, ranges, selected);

selectionDifference: function(span1, inclusive1, span2, inclusive2) {

« no previous file with comments | « no previous file | tools/turbolizer/disassembly-view.js » ('j') | tools/turbolizer/text-view.js » ('J')