[turbolizer] Improve code comments in disassembly

[turbolizer] Improve code comments in disassembly

This change analyzes and links the output of --code-comments in the disassembly view within turbolizer with the other views, such that selecting these comments will also select the respective blocks/lines/nodes within the other views. The block start comments (e.g. -- B4 start --) are linked with the blocks in the schedule phase view and vice versa. The source position comments (e.g. -- primes.js:3:10 --) select the respective spans, lines, and nodes in the JavaScript code view, the schedule phase view, and the other compilation phase views respectively, and vice versa. It also modifies the display of the line and column numbers in the source position comments to be offset from 1 instead of 0 and ignore the initial source position of the first line of code (from removal of the function name in the compiler).

Also fixed the bug where previous selections weren't being cleared properly across multiple views, adding appropriate clear calls when using the selection broker.

Committed: https://crrev.com/7f162dbcb64ac75dce44868210bcb44a8e6a17c7
Cr-Commit-Position: refs/heads/master@{#37627}

[alegil02, 2016-07-08 10:01:16]

Description was changed from

==========
Merge branch 'master' of https://chromium.googlesource.com/v8/v8 into turbopatch


[turbolizer] Improve code comments in disassembly

Block start comments select blocks in schedule and vice versa.
JavaScript code comments select code position and improved display.

BUG=
==========

to

==========
Merge branch 'master' of https://chromium.googlesource.com/v8/v8 into turbopatch


[turbolizer] Improve code comments in disassembly

Block start comments select blocks in schedule and vice versa.
JavaScript code comments select code position and improved display.

BUG=
==========

[alegil02, 2016-07-08 10:01:16]

alexander.gilday2@arm.com changed reviewers:
+ danno@chromium.org

[alegil02, 2016-07-08 10:01:58]

Description was changed from

==========
Merge branch 'master' of https://chromium.googlesource.com/v8/v8 into turbopatch


[turbolizer] Improve code comments in disassembly

Block start comments select blocks in schedule and vice versa.
JavaScript code comments select code position and improved display.

BUG=
==========

to

==========
[turbolizer] Improve code comments in disassembly

Block start comments select blocks in schedule and vice versa.
JavaScript code comments select code position and improved display.

BUG=None
==========

[danno, 2016-07-08 11:28:07]

thanks for the patch!

did you mean to add the console.log?

https://codereview.chromium.org/2133663002/diff/1/tools/turbolizer/text-view.js
File tools/turbolizer/text-view.js (right):

https://codereview.chromium.org/2133663002/diff/1/tools/turbolizer/text-view....
tools/turbolizer/text-view.js:327: console.log(li.location);
Was adding this line intentional?

[alegil02, 2016-07-08 12:41:55]

Description was changed from

==========
[turbolizer] Improve code comments in disassembly

Block start comments select blocks in schedule and vice versa.
JavaScript code comments select code position and improved display.

BUG=None
==========

to

==========
This change analyzes and links the output of --code-comments in the disassembly
view within turbolizer with the other views, such that selecting these comments
will also select the respective blocks/lines/nodes within the other views. The
block start comments (e.g. -- B4 start --) are linked with the blocks in the
schedule phase view and vice versa. The source position comments (e.g. --
primes.js:3:10 --) select the respective spans, lines, and nodes in the
JavaScript code view, the schedule phase view, and the other compilation phase
views respectively, and vice versa. It also modifies the display of the line and
column numbers in the source position comments to be offset from 1 instead of 0
and ignore the initial source position of the first line of code (from removal
of the function name in the compiler).

Also fixed the bug where previous selections weren't being cleared properly
across multiple views, adding appropriate clear calls when using the selection
broker.
==========

[alegil02, 2016-07-08 12:43:22]

On 2016/07/08 11:28:07, danno wrote:
> thanks for the patch!
> 
> did you mean to add the console.log?
> 
>
https://codereview.chromium.org/2133663002/diff/1/tools/turbolizer/text-view.js
> File tools/turbolizer/text-view.js (right):
> 
>
https://codereview.chromium.org/2133663002/diff/1/tools/turbolizer/text-view....
> tools/turbolizer/text-view.js:327: console.log(li.location);
> Was adding this line intentional?

Thanks for the review! I have made some further changes, and expanded the
description. PTAL

[danno, 2016-07-08 13:04:06]

Description was changed from

==========
This change analyzes and links the output of --code-comments in the disassembly
view within turbolizer with the other views, such that selecting these comments
will also select the respective blocks/lines/nodes within the other views. The
block start comments (e.g. -- B4 start --) are linked with the blocks in the
schedule phase view and vice versa. The source position comments (e.g. --
primes.js:3:10 --) select the respective spans, lines, and nodes in the
JavaScript code view, the schedule phase view, and the other compilation phase
views respectively, and vice versa. It also modifies the display of the line and
column numbers in the source position comments to be offset from 1 instead of 0
and ignore the initial source position of the first line of code (from removal
of the function name in the compiler).

Also fixed the bug where previous selections weren't being cleared properly
across multiple views, adding appropriate clear calls when using the selection
broker.
==========

to

==========
[turbolizer] Improve code comments in disassembly

This change analyzes and links the output of --code-comments in the disassembly
view within turbolizer with the other views, such that selecting these comments
will also select the respective blocks/lines/nodes within the other views. The
block start comments (e.g. -- B4 start --) are linked with the blocks in the
schedule phase view and vice versa. The source position comments (e.g. --
primes.js:3:10 --) select the respective spans, lines, and nodes in the
JavaScript code view, the schedule phase view, and the other compilation phase
views respectively, and vice versa. It also modifies the display of the line and
column numbers in the source position comments to be offset from 1 instead of 0
and ignore the initial source position of the first line of code (from removal
of the function name in the compiler).

Also fixed the bug where previous selections weren't being cleared properly
across multiple views, adding appropriate clear calls when using the selection
broker.
==========

[danno, 2016-07-08 13:05:25]

lgtm!

[alegil02, 2016-07-08 13:06:01]

The CQ bit was checked by alexander.gilday2@arm.com

[commit-bot: I haz the power, 2016-07-08 13:06:12]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-08 13:06:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-08 13:06:14]

The author Alexander.Gilday2@arm.com has not signed Google Contributor License
Agreement. Please visit https://cla.developers.google.com to sign and manage
CLA.

[alegil02, 2016-07-11 08:01:39]

The CQ bit was checked by alexander.gilday2@arm.com

[commit-bot: I haz the power, 2016-07-11 08:01:49]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-11 08:25:49]

Description was changed from

==========
[turbolizer] Improve code comments in disassembly

This change analyzes and links the output of --code-comments in the disassembly
view within turbolizer with the other views, such that selecting these comments
will also select the respective blocks/lines/nodes within the other views. The
block start comments (e.g. -- B4 start --) are linked with the blocks in the
schedule phase view and vice versa. The source position comments (e.g. --
primes.js:3:10 --) select the respective spans, lines, and nodes in the
JavaScript code view, the schedule phase view, and the other compilation phase
views respectively, and vice versa. It also modifies the display of the line and
column numbers in the source position comments to be offset from 1 instead of 0
and ignore the initial source position of the first line of code (from removal
of the function name in the compiler).

Also fixed the bug where previous selections weren't being cleared properly
across multiple views, adding appropriate clear calls when using the selection
broker.
==========

to

==========
[turbolizer] Improve code comments in disassembly

This change analyzes and links the output of --code-comments in the disassembly
view within turbolizer with the other views, such that selecting these comments
will also select the respective blocks/lines/nodes within the other views. The
block start comments (e.g. -- B4 start --) are linked with the blocks in the
schedule phase view and vice versa. The source position comments (e.g. --
primes.js:3:10 --) select the respective spans, lines, and nodes in the
JavaScript code view, the schedule phase view, and the other compilation phase
views respectively, and vice versa. It also modifies the display of the line and
column numbers in the source position comments to be offset from 1 instead of 0
and ignore the initial source position of the first line of code (from removal
of the function name in the compiler).

Also fixed the bug where previous selections weren't being cleared properly
across multiple views, adding appropriate clear calls when using the selection
broker.
==========

[commit-bot: I haz the power, 2016-07-11 08:25:50]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-07-11 08:25:52]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-11 08:28:33]

Description was changed from

==========
[turbolizer] Improve code comments in disassembly

This change analyzes and links the output of --code-comments in the disassembly
view within turbolizer with the other views, such that selecting these comments
will also select the respective blocks/lines/nodes within the other views. The
block start comments (e.g. -- B4 start --) are linked with the blocks in the
schedule phase view and vice versa. The source position comments (e.g. --
primes.js:3:10 --) select the respective spans, lines, and nodes in the
JavaScript code view, the schedule phase view, and the other compilation phase
views respectively, and vice versa. It also modifies the display of the line and
column numbers in the source position comments to be offset from 1 instead of 0
and ignore the initial source position of the first line of code (from removal
of the function name in the compiler).

Also fixed the bug where previous selections weren't being cleared properly
across multiple views, adding appropriate clear calls when using the selection
broker.
==========

to

==========
[turbolizer] Improve code comments in disassembly

This change analyzes and links the output of --code-comments in the disassembly
view within turbolizer with the other views, such that selecting these comments
will also select the respective blocks/lines/nodes within the other views. The
block start comments (e.g. -- B4 start --) are linked with the blocks in the
schedule phase view and vice versa. The source position comments (e.g. --
primes.js:3:10 --) select the respective spans, lines, and nodes in the
JavaScript code view, the schedule phase view, and the other compilation phase
views respectively, and vice versa. It also modifies the display of the line and
column numbers in the source position comments to be offset from 1 instead of 0
and ignore the initial source position of the first line of code (from removal
of the function name in the compiler).

Also fixed the bug where previous selections weren't being cleared properly
across multiple views, adding appropriate clear calls when using the selection
broker.

Committed: https://crrev.com/7f162dbcb64ac75dce44868210bcb44a8e6a17c7
Cr-Commit-Position: refs/heads/master@{#37627}
==========

[commit-bot: I haz the power, 2016-07-11 08:28:34]

Patchset 2 (id:??) landed as
https://crrev.com/7f162dbcb64ac75dce44868210bcb44a8e6a17c7
Cr-Commit-Position: refs/heads/master@{#37627}