Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(933)

Unified Diff: components/arc/arc_bridge_service_unittest.cc

Issue 2133653002: arc: Notify ARC instance failures via callbacks. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: . Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/arc/arc_bridge_service_unittest.cc
diff --git a/components/arc/arc_bridge_service_unittest.cc b/components/arc/arc_bridge_service_unittest.cc
index 598e54b058fc7b4fa798f2015d0e571fadc0eb19..6e74b6a70bc5e870783ae0f6a7157b96051f8bc4 100644
--- a/components/arc/arc_bridge_service_unittest.cc
+++ b/components/arc/arc_bridge_service_unittest.cc
@@ -41,12 +41,19 @@ class ArcBridgeTest : public testing::Test, public ArcBridgeService::Observer {
}
}
+ void OnBridgeAborting(ArcBridgeService::AbortReason reason) override {
+ aborted_ = true;
+ abort_reason_ = reason;
+ }
+
bool ready() const { return ready_; }
ArcBridgeService::State state() const { return state_; }
protected:
std::unique_ptr<ArcBridgeServiceImpl> service_;
std::unique_ptr<FakeArcBridgeInstance> instance_;
+ bool aborted_;
+ ArcBridgeService::AbortReason abort_reason_;
private:
void SetUp() override {
@@ -54,6 +61,8 @@ class ArcBridgeTest : public testing::Test, public ArcBridgeService::Observer {
ready_ = false;
state_ = ArcBridgeService::State::STOPPED;
+ aborted_ = false;
+ abort_reason_ = ArcBridgeService::AbortReason::GENERIC_BOOT_FAILURE;
instance_.reset(new FakeArcBridgeInstance());
service_.reset(new ArcBridgeServiceImpl(
@@ -140,6 +149,9 @@ TEST_F(ArcBridgeTest, Restart) {
ASSERT_EQ(ArcBridgeService::State::READY, state());
ASSERT_EQ(2, instance_->init_calls());
+ ASSERT_TRUE(aborted_);
+ ASSERT_EQ(ArcBridgeService::AbortReason::CRASH, abort_reason_);
hidehiko 2016/07/11 05:40:08 Could you add GENERIC_BOOT_FAILURE case, too?
Shuhei Takahashi 2016/07/11 08:25:19 Done.
+
service_->Shutdown();
ASSERT_EQ(ArcBridgeService::State::STOPPED, state());
}

Powered by Google App Engine
This is Rietveld 408576698