Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1602)

Unified Diff: components/arc/test/fake_arc_bridge_instance.h

Issue 2133653002: arc: Notify ARC instance failures via callbacks. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address hidehiko's comments. Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/arc/test/fake_arc_bridge_bootstrap.cc ('k') | components/arc/test/fake_arc_bridge_instance.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/arc/test/fake_arc_bridge_instance.h
diff --git a/components/arc/test/fake_arc_bridge_instance.h b/components/arc/test/fake_arc_bridge_instance.h
index 5a3aa47657a6e96cc610be342e7e2cb192dc51cb..ac3fd97aadb0eb074e4ab7121bd710cc0b484e2e 100644
--- a/components/arc/test/fake_arc_bridge_instance.h
+++ b/components/arc/test/fake_arc_bridge_instance.h
@@ -16,8 +16,9 @@ class FakeArcBridgeInstance : public mojom::ArcBridgeInstance {
public:
class Delegate {
public:
+ using StopReason = ArcBridgeService::StopReason;
virtual ~Delegate() = default;
- virtual void OnCrashed() = 0;
+ virtual void OnStopped(StopReason reason) = 0;
hidehiko 2016/07/13 04:55:20 Optional: to standardize other code in this CL, Ar
Shuhei Takahashi 2016/07/13 05:01:26 Oops, you're right. Thanks for catching.
};
FakeArcBridgeInstance();
@@ -41,8 +42,8 @@ class FakeArcBridgeInstance : public mojom::ArcBridgeInstance {
// The number of times Init() has been called.
int init_calls() const { return init_calls_; }
- // Simulates a crash by calling Stop() on the ArcBridgeBoostrap.
- void SimulateCrash();
+ // Stops the instance.
+ void Stop(ArcBridgeService::StopReason reason);
private:
Delegate* delegate_ = nullptr;
« no previous file with comments | « components/arc/test/fake_arc_bridge_bootstrap.cc ('k') | components/arc/test/fake_arc_bridge_instance.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698