chrome/browser/chromeos/arc/arc_auth_service.cc - Issue 2133653002: arc: Notify ARC instance failures via callbacks.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/arc/arc_auth_service.cc

Issue 2133653002: arc: Notify ARC instance failures via callbacks. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address lhchavez's comments + improve unit test. Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/chromeos/arc/arc_auth_service.cc

diff --git a/chrome/browser/chromeos/arc/arc_auth_service.cc b/chrome/browser/chromeos/arc/arc_auth_service.cc

index 6ac8869e8447b5acb705e45fd1aa9b919e218f44..f53a804ffd31e2c3d9bd7e001ee747a238d34344 100644

--- a/chrome/browser/chromeos/arc/arc_auth_service.cc

+++ b/chrome/browser/chromeos/arc/arc_auth_service.cc

@@ -195,7 +195,8 @@ void ArcAuthService::OnAuthInstanceReady() {

binding_.CreateInterfacePtrAndBind());

}

-void ArcAuthService::OnBridgeStopped() {

+void ArcAuthService::OnBridgeStopped(ArcBridgeService::StopReason reason) {

+ // TODO(crbug.com/625923): Use |reason| to report more detailed errors.

if (waiting_for_reply_) {

// Using SERVICE_UNAVAILABLE instead of UNKNOWN_ERROR, since the latter

// causes this code to not try to stop ARC, so it would retry without the