Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Unified Diff: components/arc/test/fake_arc_bridge_instance.h

Issue 2133653002: arc: Notify ARC instance failures via callbacks. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: . Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/arc/test/fake_arc_bridge_instance.h
diff --git a/components/arc/test/fake_arc_bridge_instance.h b/components/arc/test/fake_arc_bridge_instance.h
index 5a3aa47657a6e96cc610be342e7e2cb192dc51cb..f54e3b3deeca349087dfa2c102a5adc74aed20fc 100644
--- a/components/arc/test/fake_arc_bridge_instance.h
+++ b/components/arc/test/fake_arc_bridge_instance.h
@@ -17,7 +17,7 @@ class FakeArcBridgeInstance : public mojom::ArcBridgeInstance {
class Delegate {
public:
virtual ~Delegate() = default;
- virtual void OnCrashed() = 0;
+ virtual void OnCrashed(ArcBridgeService::StopReason reason) = 0;
};
FakeArcBridgeInstance();
@@ -41,8 +41,8 @@ class FakeArcBridgeInstance : public mojom::ArcBridgeInstance {
// The number of times Init() has been called.
int init_calls() const { return init_calls_; }
- // Simulates a crash by calling Stop() on the ArcBridgeBoostrap.
- void SimulateCrash();
+ // Simulates a crash.
+ void SimulateCrash(ArcBridgeService::StopReason reason);
Luis Héctor Chávez 2016/07/11 22:28:50 nit: I would rename this to Stop(), since it doesn
Shuhei Takahashi 2016/07/12 06:13:57 Done.
private:
Delegate* delegate_ = nullptr;

Powered by Google App Engine
This is Rietveld 408576698