arc: Notify ARC instance failures via callbacks.

components/arc/arc_bridge_service_unittest.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <memory>
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
 #include "base/macros.h"
 #include "base/memory/ptr_util.h"
@@ skipping 16 matching lines @@
 class ArcBridgeTest : public testing::Test, public ArcBridgeService::Observer {
  public:
   ArcBridgeTest() : ready_(false) {}
   ~ArcBridgeTest() override {}
 
   void OnBridgeReady() override {
     state_ = ArcBridgeService::State::READY;
     ready_ = true;
   }
 
-  void OnBridgeStopped() override {
+  void OnBridgeStopped(ArcBridgeService::StopReason stop_reason) override {
     state_ = ArcBridgeService::State::STOPPED;
+    stop_reason_ = stop_reason;
     message_loop_.PostTask(FROM_HERE, message_loop_.QuitWhenIdleClosure());
   }
 
   bool ready() const { return ready_; }
   ArcBridgeService::State state() const { return state_; }
 
  protected:
   std::unique_ptr<ArcBridgeServiceImpl> service_;
   std::unique_ptr<FakeArcBridgeInstance> instance_;
+  ArcBridgeService::StopReason stop_reason_;
 
  private:
   void SetUp() override {
     chromeos::DBusThreadManager::Initialize();
 
     ready_ = false;
     state_ = ArcBridgeService::State::STOPPED;
+    stop_reason_ = ArcBridgeService::StopReason::SHUTDOWN;
 
     instance_.reset(new FakeArcBridgeInstance());
     service_.reset(new ArcBridgeServiceImpl(
         base::MakeUnique<FakeArcBridgeBootstrap>(instance_.get())));
 
     service_->AddObserver(this);
   }
 
   void TearDown() override {
     service_->RemoveObserver(this);
@@ skipping 57 matching lines @@
 
   service_->SetAvailable(true);
   service_->HandleStartup();
   instance_->WaitForInitCall();
   ASSERT_EQ(ArcBridgeService::State::READY, state());
   ASSERT_EQ(1, instance_->init_calls());
 
   // Simulate a connection loss.
   service_->DisableReconnectDelayForTesting();
   service_->OnChannelClosed();
-  instance_->SimulateCrash();
+  instance_->Stop(ArcBridgeService::StopReason::CRASH);
   instance_->WaitForInitCall();
   ASSERT_EQ(ArcBridgeService::State::READY, state());
   ASSERT_EQ(2, instance_->init_calls());
 
   service_->Shutdown();
   ASSERT_EQ(ArcBridgeService::State::STOPPED, state());
 }
 
+// Makes sure OnBridgeStopped is called on stop.
+TEST_F(ArcBridgeTest, OnBridgeStopped) {
+  ASSERT_FALSE(ready());
+
+  service_->DisableReconnectDelayForTesting();
+  service_->SetAvailable(true);
+  service_->HandleStartup();
+  instance_->WaitForInitCall();
+  ASSERT_EQ(ArcBridgeService::State::READY, state());
+
+  // Simulate boot failure.
+  service_->OnChannelClosed();
+  instance_->Stop(ArcBridgeService::StopReason::GENERIC_BOOT_FAILURE);
+  instance_->WaitForInitCall();
+  ASSERT_EQ(ArcBridgeService::StopReason::GENERIC_BOOT_FAILURE, stop_reason_);
+  ASSERT_EQ(ArcBridgeService::State::READY, state());
+
+  // Simulate crash.
+  service_->OnChannelClosed();
+  instance_->Stop(ArcBridgeService::StopReason::CRASH);
+  instance_->WaitForInitCall();
+  ASSERT_EQ(ArcBridgeService::StopReason::CRASH, stop_reason_);
+  ASSERT_EQ(ArcBridgeService::State::READY, state());
+
+  // Graceful shutdown.
+  service_->Shutdown();
+  ASSERT_EQ(ArcBridgeService::StopReason::SHUTDOWN, stop_reason_);
+  ASSERT_EQ(ArcBridgeService::State::STOPPED, state());
+}
+
 // Removing the same observer more than once should be okay.
 TEST_F(ArcBridgeTest, RemoveObserverTwice) {
   ASSERT_FALSE(ready());
   service_->RemoveObserver(this);
   // The teardown method will also remove |this|.
 }
 
 // Removing an unknown observer should be allowed.
 TEST_F(ArcBridgeTest, RemoveUnknownObserver) {
   ASSERT_FALSE(ready());
   auto dummy_observer = base::MakeUnique<DummyObserver>();
   service_->RemoveObserver(dummy_observer.get());
 }
 
 }  // namespace arc