Resetting metrics ids on clump detection.

chrome/browser/metrics/metrics_service.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // This file defines a service that collects information about the user
 // experience in order to help improve future versions of the app.
 
 #ifndef CHROME_BROWSER_METRICS_METRICS_SERVICE_H_
 #define CHROME_BROWSER_METRICS_METRICS_SERVICE_H_
 
@@ skipping 124 matching lines @@
   MetricsService();
   virtual ~MetricsService();
 
   // Initializes metrics recording state. Updates various bookkeeping values in
   // prefs and sets up the scheduler. This is a separate function rather than
   // being done by the constructor so that field trials could be created before
   // this is run. Takes |reporting_state| parameter which specifies whether UMA
   // is enabled.
   void InitializeMetricsRecordingState(ReportingState reporting_state);
 
+  // Initializes low entropy source, and, if the client has
+  void InitializeVariationsState(bool recording_enabled);

[Alexei Svitkine (slow), 2014/03/28 15:00:17]

It's not really variations state, since UMA client id isn't just for variations.

Maybe InitializeMetricsIDs()?

[jwd, 2014/03/28 16:23:50]

Done.

+
   // Starts the metrics system, turning on recording and uploading of metrics.
   // Should be called when starting up with metrics enabled, or when metrics
   // are turned on.
   void Start();
 
   // Starts the metrics system in a special test-only mode. Metrics won't ever
   // be uploaded or persisted in this mode, but metrics will be recorded in
   // memory.
   void StartRecordingForTests();
 
@@ skipping 131 matching lines @@
   // is registered for a given trial name will be recorded. The values passed
   // in must not correspond to any real field trial in the code.
   // To use this method, SyntheticTrialGroup should friend your class.
   void RegisterSyntheticFieldTrial(const SyntheticTrialGroup& trial_group);
 
   // Check if this install was cloned or imaged from another machine. If a
   // clone is detected, reset the client id and low entropy source. This
   // should not be called more than once.
   void CheckForClonedInstall();
 
+  void ResetVariationsState();

[Alexei Svitkine (slow), 2014/03/28 15:00:17]

Private?

[jwd, 2014/03/28 16:23:50]

Done.

+
  private:
   // The MetricsService has a lifecycle that is stored as a state.
   // See metrics_service.cc for description of this lifecycle.
   enum State {
     INITIALIZED,                    // Constructor was called.
     INIT_TASK_SCHEDULED,            // Waiting for deferred init tasks to
                                     // complete.
     INIT_TASK_DONE,                 // Waiting for timer to send initial log.
     SENDING_INITIAL_STABILITY_LOG,  // Initial stability log being sent.
     SENDING_INITIAL_METRICS_LOG,    // Initial metrics log being sent.
@@ skipping 210 matching lines @@
 
   // Returns a list of synthetic field trials that were active for the entire
   // duration of the current log.
   void GetCurrentSyntheticFieldTrials(
       std::vector<chrome_variations::ActiveGroupId>* synthetic_trials);
 
   base::ActionCallback action_callback_;
 
   content::NotificationRegistrar registrar_;
 
+  bool variations_state_initialized_;
+
   // Indicate whether recording and reporting are currently happening.
   // These should not be set directly, but by calling SetRecording and
   // SetReporting.
   bool recording_active_;
   bool reporting_active_;
 
   // Indicate whether test mode is enabled, where the initial log should never
   // be cut, and logs are neither persisted nor uploaded.
   bool test_mode_active_;
 
@@ skipping 132 matching lines @@
 
   // Returns true if crash reporting is enabled.  This is set at the platform
   // level for Android and ChromeOS, and otherwise is the same as
   // IsMetricsReportingEnabled for desktop Chrome.
   static bool IsCrashReportingEnabled();
 
   DISALLOW_IMPLICIT_CONSTRUCTORS(MetricsServiceHelper);
 };
 
 #endif  // CHROME_BROWSER_METRICS_METRICS_SERVICE_H_