chrome/browser/metrics/metrics_service_unittest.cc - Issue 213363004: Resetting metrics ids on clump detection.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/metrics/metrics_service_unittest.cc

Issue 213363004: Resetting metrics ids on clump detection. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "chrome/browser/metrics/metrics_service.h"	5 #include "chrome/browser/metrics/metrics_service.h"

6	6

7 #include <ctype.h>	7 #include <ctype.h>

8 #include <string>	8 #include <string>

9	9

10 #include "base/command_line.h"	10 #include "base/command_line.h"

(...skipping 356 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
367 GetLocalState()->SetBoolean(crash_pref, true);	367 GetLocalState()->SetBoolean(crash_pref, true);

368 EXPECT_TRUE(MetricsServiceHelper::IsCrashReportingEnabled());	368 EXPECT_TRUE(MetricsServiceHelper::IsCrashReportingEnabled());

369 GetLocalState()->ClearPref(crash_pref);	369 GetLocalState()->ClearPref(crash_pref);

370 EXPECT_FALSE(MetricsServiceHelper::IsCrashReportingEnabled());	370 EXPECT_FALSE(MetricsServiceHelper::IsCrashReportingEnabled());

371 #endif // !defined(OS_CHROMEOS)	371 #endif // !defined(OS_CHROMEOS)

372 #else // defined(GOOGLE_CHROME_BUILD)	372 #else // defined(GOOGLE_CHROME_BUILD)

373 // Chromium branded browsers never have crash reporting enabled.	373 // Chromium branded browsers never have crash reporting enabled.

374 EXPECT_FALSE(MetricsServiceHelper::IsCrashReportingEnabled());	374 EXPECT_FALSE(MetricsServiceHelper::IsCrashReportingEnabled());

375 #endif // defined(GOOGLE_CHROME_BUILD)	375 #endif // defined(GOOGLE_CHROME_BUILD)

376 }	376 }

	377

	378 TEST_F(MetricsServiceTest, ResetMetricsIDs) {

	379 MetricsService service;

	380 service.ForceC
	Alexei Svitkine (slow) 2014/03/28 19:02:50 What's going on here? What's going on here? jwd 2014/03/28 19:43:15 Wasn't done yet. Next patch has actual content. Show quoted text On 2014/03/28 19:02:50, Alexei Svitkine wrote: > What's going on here? Wasn't done yet. Next patch has actual content.
	381 service.GetLowEntropySource();

	382 }

OLD	NEW

« chrome/browser/metrics/metrics_service.cc ('K') | « chrome/browser/metrics/metrics_service.cc ('k') | chrome/common/pref_names.h » ('j') | tools/metrics/histograms/histograms.xml » ('J')