Resetting metrics ids on clump detection.

chrome/browser/metrics/cloned_install_detector.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/metrics/cloned_install_detector.h"
 
 #include "base/bind.h"
 #include "base/metrics/histogram.h"
 #include "base/prefs/pref_registry_simple.h"
 #include "base/prefs/pref_service.h"
@@ skipping 31 matching lines @@
 
 }  // namespace
 
 ClonedInstallDetector::ClonedInstallDetector(MachineIdProvider* raw_id_provider)
     : raw_id_provider_(raw_id_provider),
       weak_ptr_factory_(this) {}
 
 ClonedInstallDetector::~ClonedInstallDetector() {}
 
 void ClonedInstallDetector::CheckForClonedInstall(PrefService* local_state) {
-  content::BrowserThread::PostTaskAndReplyWithResult(
+  DVLOG(2) << "\n\nabout to post some tasks.\n\n";
+  bool res = content::BrowserThread::PostTaskAndReplyWithResult(
       content::BrowserThread::FILE,
       FROM_HERE,
       base::Bind(&metrics::MachineIdProvider::GetMachineId,
                  raw_id_provider_),
       base::Bind(&metrics::ClonedInstallDetector::SaveMachineId,
                  weak_ptr_factory_.GetWeakPtr(),
                  local_state));
+  DVLOG(2) << "\n\ntask posted? " << res << "\n\n";
 }
 
 void ClonedInstallDetector::SaveMachineId(
     PrefService* local_state,
     std::string raw_id) {
+  DVLOG(2) << "\n\nsaving id: " << raw_id << "\n\n";
   if (raw_id.empty()) {
     LogMachineIdState(ID_GENERATION_FAILED);
     local_state->ClearPref(prefs::kMetricsMachineId);
     return;
   }
 
   int hashed_id = HashRawId(raw_id);
 
   MachineIdState id_state = ID_NO_STORED_VALUE;
   if (local_state->HasPrefPath(prefs::kMetricsMachineId)) {
-    id_state = local_state->GetInteger(prefs::kMetricsMachineId) == hashed_id ?
-        ID_UNCHANGED : ID_CHANGED;
+    if (local_state->GetInteger(prefs::kMetricsMachineId) != hashed_id) {
+      id_state = ID_CHANGED;
+      local_state->SetBoolean(prefs::kMetricsCloneDetected, true);

[Alexei Svitkine (slow), 2014/03/26 21:34:50]

Is there a way we can make the querying and setting of this pref happen in the
same class? i.e. either both in MetricsService or both in ClonedInstallDetector?

Maybe make ClonedInstallDetector::CheckForClonedInstall() take a callback that's
posted if we detect a cloned install and then have the logic be in
MetricsService related to the pref.

+    } else {
+      id_state = ID_UNCHANGED;
+    }
   }
 
   LogMachineIdState(id_state);
 
   local_state->SetInteger(prefs::kMetricsMachineId, hashed_id);
 }
 
 // static
 void ClonedInstallDetector::RegisterPrefs(PrefRegistrySimple* registry) {
   registry->RegisterIntegerPref(prefs::kMetricsMachineId, 0);
+  registry->RegisterBooleanPref(prefs::kMetricsCloneDetected, false);
 }
 
 }  // namespace metrics