Delete some dead code.

net/socket/ssl_client_socket_nss.cc

Index: net/socket/ssl_client_socket_nss.cc
diff --git a/net/socket/ssl_client_socket_nss.cc b/net/socket/ssl_client_socket_nss.cc
index ca5a6891b89f7efebd7747cf0e67c32e896502d3..71836cc280503f663d8eac6e3b84dc1aea1d6002 100644
--- a/net/socket/ssl_client_socket_nss.cc
+++ b/net/socket/ssl_client_socket_nss.cc
@@ -333,7 +333,7 @@ class PeerCertificateChain {
   size_t size() const { return certs_.size(); }
 
   CERTCertificate* operator[](size_t index) const {
-    DCHECK_LT(index, certs_.size());
+    DCHECK_LT(index, size());
     return certs_[index];
   }
 
@@ -356,15 +356,15 @@ PeerCertificateChain& PeerCertificateChain::operator=(
     return *this;
 
   Reset(NULL);
-  certs_.reserve(other.certs_.size());
-  for (size_t i = 0; i < other.certs_.size(); ++i)
+  certs_.reserve(other.size());
+  for (size_t i = 0; i < other.size(); ++i)

[Ryan Sleevi, 2014/03/26 21:22:45]

This = not lgtm

Not sure why Clang griped about this, but this change is inconsistent with how
line 361 works.

[Nico, 2014/03/26 21:35:12]

Why is this? It calls others.size(), not this->size().

(clang remarked that size() from line 333 was unused, so I figured I'd use it
instead of deleting it)

[Ryan Sleevi, 2014/03/26 21:42:20]

Because it's inconsistently coupling implementations - size() [a public API]
with certs_ [an implementation detail]

If size() is used, it should be using operator[] (line 335)
If certs_[] is used, it should be coupled with certs_.size() (which it's doing
today)

I think we can just nuke size() altogether - ::Core now only uses empty() before
accessing [0], and the bits that accessed the other indices are rolled into this
class, via AsStringPieceVector().

[Nico, 2014/03/26 21:43:52]

Ok, deleted size() instead.

     certs_.push_back(CERT_DupCertificate(other.certs_[i]));
 
   return *this;
 }
 
 void PeerCertificateChain::Reset(PRFileDesc* nss_fd) {
-  for (size_t i = 0; i < certs_.size(); ++i)
+  for (size_t i = 0; i < size(); ++i)
     CERT_DestroyCertificate(certs_[i]);
   certs_.clear();
 
@@ -385,8 +385,8 @@ void PeerCertificateChain::Reset(PRFileDesc* nss_fd) {
 
 std::vector<base::StringPiece>
 PeerCertificateChain::AsStringPieceVector() const {
-  std::vector<base::StringPiece> v(certs_.size());
-  for (unsigned i = 0; i < certs_.size(); i++) {
+  std::vector<base::StringPiece> v(size());
+  for (unsigned i = 0; i < size(); i++) {

[Ryan Sleevi, 2014/03/26 21:22:45]

Ditto this - inconsistent with using certs_[i] immediately below.

[Nico, 2014/03/26 21:35:12]

Ditto "I don't understand" :-)

     v[i] = base::StringPiece(
         reinterpret_cast<const char*>(certs_[i]->derCert.data),
         certs_[i]->derCert.len);