Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(371)

Issue 2133563002: Type test tests for js interop (Closed)

Created:
4 years, 5 months ago by sra1
Modified:
4 years, 5 months ago
Reviewers:
Jacob
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Avoid script injection #

Unified diffs Side-by-side diffs Delta from patch set Stats (+164 lines, -5 lines) Patch
M tests/html/html.status View 1 1 chunk +3 lines, -0 lines 0 comments Download
A tests/html/js_type_test.dart View 1 1 chunk +151 lines, -0 lines 0 comments Download
A + tests/html/js_type_test.html View 1 1 chunk +9 lines, -4 lines 0 comments Download
A + tests/html/js_type_test_js.js View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
sra1
4 years, 5 months ago (2016-07-08 03:25:00 UTC) #1
Jacob
lgtm
4 years, 5 months ago (2016-07-08 19:27:53 UTC) #2
sra1
Committed patchset #1 (id:1) manually as 081eec517b890dc7d07176fe283949070f8ccfae (presubmit successful).
4 years, 5 months ago (2016-07-09 01:52:38 UTC) #4
sra1
4 years, 5 months ago (2016-07-14 00:49:05 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
0b4a3d8da79e142842cdf0a15a26bbc5baa3cb84 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698