Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(264)

Issue 2133553002: Add logging of DXVAVDA errors with line numbers. (Closed)

Created:
4 years, 5 months ago by jbauman
Modified:
4 years, 5 months ago
CC:
chromium-reviews, posciak+watch_chromium.org, piman+watch_chromium.org, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add logging of DXVAVDA errors with line numbers. This will help us track down the causes of video decoding errors in about:gpu and on the GPU bots. Logging only the line number should help prevent code bloat due to logging strings (and code) in release builds, and should make it easy to identify exactly what code failed. BUG=626524 Committed: https://crrev.com/2ddbb3fc8fa992d78b63864aeddf0e54a4675c51 Cr-Commit-Position: refs/heads/master@{#404463}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -0 lines) Patch
M media/gpu/dxva_picture_buffer_win.cc View 1 chunk +9 lines, -0 lines 0 comments Download
M media/gpu/dxva_video_decode_accelerator_win.cc View 3 chunks +7 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
jbauman
4 years, 5 months ago (2016-07-08 10:02:37 UTC) #2
sandersd (OOO until July 31)
lgtm. Is this log always clean during normal operation?
4 years, 5 months ago (2016-07-08 18:56:41 UTC) #3
jbauman
On 2016/07/08 18:56:41, sandersd wrote: > lgtm. > > Is this log always clean during ...
4 years, 5 months ago (2016-07-08 19:28:32 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2133553002/1
4 years, 5 months ago (2016-07-08 19:29:25 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-08 19:35:06 UTC) #7
commit-bot: I haz the power
4 years, 5 months ago (2016-07-08 19:36:50 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2ddbb3fc8fa992d78b63864aeddf0e54a4675c51
Cr-Commit-Position: refs/heads/master@{#404463}

Powered by Google App Engine
This is Rietveld 408576698