src/log.h - Issue 2133533002: Make use of v8::TickSample instead of v8::internal::TickSample in logger.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/log.h

Issue 2133533002: Make use of v8::TickSample instead of v8::internal::TickSample in logger. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/log.h

diff --git a/src/log.h b/src/log.h

index 8b8ae55962436cfd613e8ec37650f7262461adb7..83d98b66c57d221d60e532652f7d366f3c987b2e 100644

--- a/src/log.h

+++ b/src/log.h

@@ -17,9 +17,7 @@

namespace v8 {

-namespace base {

-class Semaphore;

+struct TickSample;

namespace sampler {

class Sampler;

@@ -67,9 +65,9 @@ class CpuProfiler;

class Isolate;

class Log;

class Profiler;

-class Ticker;

+class ProfilerListener;

class RuntimeCallTimer;

-struct TickSample;

+class Ticker;

#undef LOG

#define LOG(isolate, Call) \

@@ -88,7 +86,6 @@ class JitLogger;

class PerfBasicLogger;

class LowLevelLogger;

class PerfJitLogger;

Yang 2016/07/08 06:05:22 Let's also move these forward-declarations to the

alph 2016/07/08 21:45:43 Done.

-class ProfilerListener;

class Logger : public CodeEventListener {

public:

« no previous file with comments | « no previous file | src/log.cc » ('j') | no next file with comments »