Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Issue 2133533002: Make use of v8::TickSample instead of v8::internal::TickSample in logger. (Closed)

Created:
4 years, 5 months ago by alph
Modified:
4 years, 5 months ago
Reviewers:
lpy, Yang
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Make use of v8::TickSample instead of v8::internal::TickSample in logger. BUG=v8:4789 Committed: https://crrev.com/c3a16f0a9f0976411ee25df627534be5f6955c32 Committed: https://crrev.com/69fd22da2a108db0f4dcb3a6e42794be355b51f8 Cr-Original-Commit-Position: refs/heads/master@{#37618} Cr-Commit-Position: refs/heads/master@{#37660}

Patch Set 1 #

Total comments: 2

Patch Set 2 : addressing comments. #

Patch Set 3 : rebaseline #

Patch Set 4 : rebaseline 2 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -34 lines) Patch
M src/log.h View 1 3 chunks +7 lines, -11 lines 0 comments Download
M src/log.cc View 1 2 3 12 chunks +19 lines, -21 lines 0 comments Download
M src/profiler/profile-generator.h View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 21 (9 generated)
alph
ptal
4 years, 5 months ago (2016-07-07 23:58:39 UTC) #2
lpy
lgtm
4 years, 5 months ago (2016-07-08 00:02:07 UTC) #3
Yang
lgtm. https://codereview.chromium.org/2133533002/diff/1/src/log.h File src/log.h (right): https://codereview.chromium.org/2133533002/diff/1/src/log.h#newcode88 src/log.h:88: class PerfJitLogger; Let's also move these forward-declarations to ...
4 years, 5 months ago (2016-07-08 06:05:23 UTC) #4
alph
https://codereview.chromium.org/2133533002/diff/1/src/log.h File src/log.h (right): https://codereview.chromium.org/2133533002/diff/1/src/log.h#newcode88 src/log.h:88: class PerfJitLogger; On 2016/07/08 06:05:22, Yang wrote: > Let's ...
4 years, 5 months ago (2016-07-08 21:45:43 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2133533002/20001
4 years, 5 months ago (2016-07-09 00:49:45 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-09 01:19:26 UTC) #9
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/c3a16f0a9f0976411ee25df627534be5f6955c32 Cr-Commit-Position: refs/heads/master@{#37618}
4 years, 5 months ago (2016-07-09 01:20:27 UTC) #11
Michael Achenbach
Note: Collective revert: https://codereview.chromium.org/2138643003/
4 years, 5 months ago (2016-07-11 07:40:01 UTC) #12
alph
This patch is not a culprit. Relanding.
4 years, 5 months ago (2016-07-12 01:39:06 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2133533002/60001
4 years, 5 months ago (2016-07-12 01:43:14 UTC) #17
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 5 months ago (2016-07-12 02:10:15 UTC) #19
commit-bot: I haz the power
4 years, 5 months ago (2016-07-12 02:13:21 UTC) #21
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/69fd22da2a108db0f4dcb3a6e42794be355b51f8
Cr-Commit-Position: refs/heads/master@{#37660}

Powered by Google App Engine
This is Rietveld 408576698