Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(594)

Issue 213353005: Refactor gpu::Buffer to allow different types of backing (Closed)

Created:
6 years, 8 months ago by piman
Modified:
6 years, 8 months ago
CC:
chromium-reviews, viettrungluu+watch_chromium.org, jam, sievers+watch_chromium.org, jbauman+watch_chromium.org, Aaron Boodman, darin-cc_chromium.org, kalyank, piman+watch_chromium.org, danakj+watch_chromium.org, abarth-chromium, ben+mojo_chromium.org, darin (slow to review)
Visibility:
Public.

Description

Refactor gpu::Buffer to allow different types of backing This is so that we can use either base::SharedMemory or mojo::SharedBuffer to back gpu::Buffer. BUG=333157 R=darin@chromium.org, viettrungluu@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=261228

Patch Set 1 #

Patch Set 2 : fix pointer alignment in tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+133 lines, -84 lines) Patch
M content/common/gpu/client/command_buffer_proxy_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/common/gpu/gpu_command_buffer_stub.cc View 2 chunks +9 lines, -4 lines 0 comments Download
M gpu/command_buffer/client/client_test_helper.cc View 1 chunk +2 lines, -1 line 0 comments Download
M gpu/command_buffer/client/mapped_memory_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M gpu/command_buffer/common/buffer.h View 2 chunks +38 lines, -3 lines 0 comments Download
M gpu/command_buffer/common/buffer.cc View 1 chunk +16 lines, -4 lines 0 comments Download
M gpu/command_buffer/service/command_buffer_service.h View 1 chunk +5 lines, -8 lines 0 comments Download
M gpu/command_buffer/service/command_buffer_service.cc View 3 chunks +9 lines, -12 lines 0 comments Download
M gpu/command_buffer/service/common_decoder_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.cc View 1 chunk +1 line, -1 line 0 comments Download
M gpu/command_buffer/service/gpu_scheduler_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M gpu/command_buffer/service/query_manager_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M gpu/command_buffer/service/transfer_buffer_manager.h View 2 chunks +5 lines, -8 lines 0 comments Download
M gpu/command_buffer/service/transfer_buffer_manager.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M gpu/command_buffer/service/transfer_buffer_manager_unittest.cc View 1 3 chunks +26 lines, -25 lines 0 comments Download
M mojo/gles2/command_buffer_client_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/gles2/command_buffer_impl.cc View 2 chunks +6 lines, -2 lines 0 comments Download
M ppapi/proxy/ppapi_command_buffer_proxy.cc View 1 chunk +1 line, -3 lines 0 comments Download
M ppapi/proxy/ppb_graphics_3d_proxy.cc View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
piman
epenner: please review. Turns out, this looks more like your previous CL re: gpu::Buffer refactor. ...
6 years, 8 months ago (2014-04-02 01:44:56 UTC) #1
epennerAtGoogle
On 2014/04/02 01:44:56, piman wrote: > epenner: please review. Turns out, this looks more like ...
6 years, 8 months ago (2014-04-02 02:13:32 UTC) #2
darin (slow to review)
LGTM
6 years, 8 months ago (2014-04-02 06:34:06 UTC) #3
viettrungluu
lgtm too
6 years, 8 months ago (2014-04-02 16:03:17 UTC) #4
piman
The CQ bit was checked by piman@chromium.org
6 years, 8 months ago (2014-04-02 17:44:26 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/piman@chromium.org/213353005/20001
6 years, 8 months ago (2014-04-02 17:46:36 UTC) #6
piman
6 years, 8 months ago (2014-04-02 23:54:13 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 manually as r261228 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698