Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(320)

Unified Diff: tools/gn/escape.cc

Issue 213353004: GN: Move towards only using / on Windows (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: only generate / in various places Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/gn/escape.cc
diff --git a/tools/gn/escape.cc b/tools/gn/escape.cc
index e10e24a2b68c48f6a5c0454e33ecd036879320e0..763b2c6d5fdac480d5cea424c94c845f28320cde 100644
--- a/tools/gn/escape.cc
+++ b/tools/gn/escape.cc
@@ -45,11 +45,7 @@ void EscapeStringToString(const base::StringPiece& str,
} else if (str[i] == '\'' && (options.mode & ESCAPE_JSON)) {
dest->push_back('\\');
dest->push_back('\'');
-#if defined(OS_WIN)
- } else if (str[i] == '/' && options.convert_slashes) {
- // Convert slashes on Windows if requested.
- dest->push_back('\\');
-#else
+#if !defined(OS_WIN)
} else if (str[i] == '\\' && (options.mode & ESCAPE_SHELL)) {
// For non-Windows shell, escape backslashes.
dest->push_back('\\');
« tools/gn/build_settings.cc ('K') | « tools/gn/escape.h ('k') | tools/gn/filesystem_utils.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698