Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: tools/gn/setup.cc

Issue 213353004: GN: Move towards only using / on Windows (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« base/files/file_path.h ('K') | « tools/gn/path_output_unittest.cc ('k') | tools/gn/source_dir.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/setup.cc
diff --git a/tools/gn/setup.cc b/tools/gn/setup.cc
index 759b40a4d64f600d89d5ac21ae0206a18f3eddcc..99e928d23034e3a042a87695f64ad3faa41d3384 100644
--- a/tools/gn/setup.cc
+++ b/tools/gn/setup.cc
@@ -294,11 +294,9 @@ bool Setup::FillSourceDir(const CommandLine& cmdline) {
}
bool Setup::FillBuildDir(const std::string& build_dir) {
- std::string normalized_build_dir = PathToSystem(build_dir);
-
SourceDir resolved =
SourceDirForCurrentDirectory(build_settings_.root_path()).
- ResolveRelativeDir(normalized_build_dir);
+ ResolveRelativeDir(build_dir);
if (resolved.is_null()) {
Err(Location(), "Couldn't resolve build directory.",
"The build directory supplied (\"" + build_dir + "\") was not valid.").
« base/files/file_path.h ('K') | « tools/gn/path_output_unittest.cc ('k') | tools/gn/source_dir.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698