Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Issue 2133503004: MIPS: [turbofan] Make sure binop results do not overwrite deoptimization inputs on arm. (Closed)

Created:
4 years, 5 months ago by miran.karic
Modified:
4 years, 5 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS: [turbofan] Make sure binop results do not overwrite deoptimization inputs on arm. Port e60c4053c7f9d6e44b995c77ab3ec561aec83c9c this fix applies to mips as well. BUG= TEST=mjsunit/regress/regress-int32-truncation Committed: https://crrev.com/91f63b2ee42307bb5566b60e2d6deb0bc7c795ce Cr-Commit-Position: refs/heads/master@{#37610}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -2 lines) Patch
M src/compiler/mips/instruction-selector-mips.cc View 1 chunk +8 lines, -1 line 0 comments Download
M src/compiler/mips64/instruction-selector-mips64.cc View 1 chunk +8 lines, -1 line 0 comments Download

Messages

Total messages: 12 (5 generated)
miran.karic
PTAL
4 years, 5 months ago (2016-07-08 10:12:15 UTC) #2
balazs.kilvady
LGTM
4 years, 5 months ago (2016-07-08 10:15:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2133503004/1
4 years, 5 months ago (2016-07-08 10:37:26 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2133503004/1
4 years, 5 months ago (2016-07-08 12:55:29 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-08 12:57:12 UTC) #9
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-08 12:57:16 UTC) #10
commit-bot: I haz the power
4 years, 5 months ago (2016-07-08 12:59:26 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/91f63b2ee42307bb5566b60e2d6deb0bc7c795ce
Cr-Commit-Position: refs/heads/master@{#37610}

Powered by Google App Engine
This is Rietveld 408576698