Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(336)

Unified Diff: chrome/browser/chromeos/arc/arc_policy_bridge.cc

Issue 2133503002: arc: Revamp the ArcBridgeService interface (Closed) Base URL: https://chromium.googlesource.com/a/chromium/src.git@master
Patch Set: Fix ui_arc_unittests Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/arc/arc_policy_bridge.cc
diff --git a/chrome/browser/chromeos/arc/arc_policy_bridge.cc b/chrome/browser/chromeos/arc/arc_policy_bridge.cc
index 3cbc920e09cb0042bcc5b64124f21e56eec6d9f5..5ff18798d3af7c548d7ded3902cbaed6331b2124 100644
--- a/chrome/browser/chromeos/arc/arc_policy_bridge.cc
+++ b/chrome/browser/chromeos/arc/arc_policy_bridge.cc
@@ -234,7 +234,7 @@ std::string GetFilteredJSONPolicies(const policy::PolicyMap& policy_map) {
ArcPolicyBridge::ArcPolicyBridge(ArcBridgeService* bridge_service)
: ArcService(bridge_service), binding_(this) {
VLOG(2) << "ArcPolicyBridge::ArcPolicyBridge";
- arc_bridge_service()->AddObserver(this);
+ arc_bridge_service()->policy()->AddObserver(this);
}
ArcPolicyBridge::ArcPolicyBridge(ArcBridgeService* bridge_service,
@@ -243,36 +243,30 @@ ArcPolicyBridge::ArcPolicyBridge(ArcBridgeService* bridge_service,
binding_(this),
policy_service_(policy_service) {
VLOG(2) << "ArcPolicyBridge::ArcPolicyBridge(bridge_service, policy_service)";
- arc_bridge_service()->AddObserver(this);
+ arc_bridge_service()->policy()->AddObserver(this);
}
ArcPolicyBridge::~ArcPolicyBridge() {
VLOG(2) << "ArcPolicyBridge::~ArcPolicyBridge";
- arc_bridge_service()->RemoveObserver(this);
+ arc_bridge_service()->policy()->RemoveObserver(this);
}
void ArcPolicyBridge::OverrideIsManagedForTesting(bool is_managed) {
is_managed_ = is_managed;
}
-void ArcPolicyBridge::OnPolicyInstanceReady() {
+void ArcPolicyBridge::OnInstanceReady(mojom::PolicyInstance* policy_instance,
+ uint32_t version) {
VLOG(1) << "ArcPolicyBridge::OnPolicyInstanceReady";
if (policy_service_ == nullptr) {
InitializePolicyService();
}
policy_service_->AddObserver(policy::POLICY_DOMAIN_CHROME, this);
- mojom::PolicyInstance* const policy_instance =
- arc_bridge_service()->policy_instance();
- if (!policy_instance) {
- LOG(ERROR) << "OnPolicyInstanceReady called, but no policy instance found";
- return;
- }
-
policy_instance->Init(binding_.CreateInterfacePtrAndBind());
}
-void ArcPolicyBridge::OnPolicyInstanceClosed() {
+void ArcPolicyBridge::OnInstanceClosed(mojom::PolicyInstance*) {
VLOG(1) << "ArcPolicyBridge::OnPolicyInstanceClosed";
policy_service_->RemoveObserver(policy::POLICY_DOMAIN_CHROME, this);
policy_service_ = nullptr;
@@ -296,8 +290,8 @@ void ArcPolicyBridge::OnPolicyUpdated(const policy::PolicyNamespace& ns,
const policy::PolicyMap& previous,
const policy::PolicyMap& current) {
VLOG(1) << "ArcPolicyBridge::OnPolicyUpdated";
- DCHECK(arc_bridge_service()->policy_instance());
- arc_bridge_service()->policy_instance()->OnPolicyUpdated();
+ DCHECK(arc_bridge_service()->policy()->instance());
+ arc_bridge_service()->policy()->instance()->OnPolicyUpdated();
}
void ArcPolicyBridge::InitializePolicyService() {

Powered by Google App Engine
This is Rietveld 408576698