Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(357)

Unified Diff: components/arc/crash_collector/arc_crash_collector_bridge.h

Issue 2133503002: arc: Revamp the ArcBridgeService interface (Closed) Base URL: https://chromium.googlesource.com/a/chromium/src.git@master
Patch Set: More rebasing Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/arc/crash_collector/arc_crash_collector_bridge.h
diff --git a/components/arc/crash_collector/arc_crash_collector_bridge.h b/components/arc/crash_collector/arc_crash_collector_bridge.h
index 4446bd34773c6164a70ba38a1113e241bc394c67..cb234759a8419f3563a86883122c8f299effeb34 100644
--- a/components/arc/crash_collector/arc_crash_collector_bridge.h
+++ b/components/arc/crash_collector/arc_crash_collector_bridge.h
@@ -10,20 +10,22 @@
#include "base/macros.h"
#include "components/arc/arc_bridge_service.h"
#include "components/arc/arc_service.h"
+#include "components/arc/instance_holder.h"
#include "mojo/public/cpp/bindings/binding.h"
namespace arc {
// Relays dumps for non-native ARC crashes to the crash reporter in Chrome OS.
-class ArcCrashCollectorBridge : public ArcService,
- public ArcBridgeService::Observer,
- public mojom::CrashCollectorHost {
+class ArcCrashCollectorBridge
+ : public ArcService,
+ public InstanceHolder<mojom::CrashCollectorInstance>::Observer,
+ public mojom::CrashCollectorHost {
public:
explicit ArcCrashCollectorBridge(ArcBridgeService* bridge);
~ArcCrashCollectorBridge() override;
- // ArcBridgeService::Observer overrides.
- void OnCrashCollectorInstanceReady() override;
+ // InstanceHolder<mojom::CrashCollectorInstance>::Observer overrides.
+ void OnInstanceReady() override;
// mojom::CrashCollectorHost overrides.
void DumpCrash(const mojo::String& type, mojo::ScopedHandle pipe) override;
« no previous file with comments | « components/arc/clipboard/arc_clipboard_bridge.cc ('k') | components/arc/crash_collector/arc_crash_collector_bridge.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698