Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Unified Diff: scripts/slave/recipes/ios/try.py

Issue 2133483002: Fix configuration of goma in iOS recipes. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master
Patch Set: improve wording in comment Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « scripts/slave/recipe_modules/ios/api.py ('k') | scripts/slave/recipes/ios/try.expected/gn.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: scripts/slave/recipes/ios/try.py
diff --git a/scripts/slave/recipes/ios/try.py b/scripts/slave/recipes/ios/try.py
index 1d38f93adb790bc207e32562625a2d624830d746..938bcac00f88c89d5278eecc18f9c87ae344b34b 100644
--- a/scripts/slave/recipes/ios/try.py
+++ b/scripts/slave/recipes/ios/try.py
@@ -220,4 +220,42 @@ def GenTests(api):
})
)
+ yield (
+ api.test('gyp_goma')
+ + api.platform('mac', 64)
+ + api.properties(patch_url='patch url')
+ + api.properties(
+ buildername='ios-simulator',
+ buildnumber='0',
+ issue=123456,
+ mastername='tryserver.fake',
+ patchset=1,
+ rietveld='fake://rietveld.url',
+ slavename='fake-vm',
+ )
+ + api.ios.make_test_build_config({
+ 'xcode version': 'fake xcode version',
+ 'GYP_DEFINES': [
+ 'OS=ios',
+ 'gomadir=$(goma_dir)',
+ 'target_subarch=both',
+ 'use_goma=1',
+ ],
+ 'gn_args': [
+ ],
+ 'use_analyze': True,
+ 'mb_type': 'gyp',
+ 'compiler': 'ninja',
+ 'configuration': 'Debug',
+ 'sdk': 'iphonesimulator8.0',
+ 'tests': [
+ {
+ 'app': 'fake tests',
+ 'device type': 'fake device',
+ 'os': '8.1',
+ },
+ ],
+ })
+ )
+
« no previous file with comments | « scripts/slave/recipe_modules/ios/api.py ('k') | scripts/slave/recipes/ios/try.expected/gn.json » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698