Fix configuration of goma in iOS recipes.

scripts/slave/recipe_modules/ios/api.py

 # Copyright 2015 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import copy
 
 from recipe_engine import recipe_api
 
 
 class iOSApi(recipe_api.RecipeApi):
@@ skipping 195 matching lines @@
       self.package_repo_resource(
         'scripts', 'slave', 'ios', 'find_xcode.py'),
       '--json-file', self.m.json.output(),
       '--version', self.__config['xcode version'],
     ], step_test_data=lambda: self.m.json.test_api.output({}))
 
     cfg = self.m.chromium.make_config()
 
     if self.using_gyp:
       cfg.gyp_env.GYP_CROSSCOMPILE = 1
-      cfg.gyp_env.GYP_DEFINES = copy.deepcopy(self.__config['GYP_DEFINES'])
+      if isinstance(self.__config['GYP_DEFINES'], dict):
+        cfg.gyp_env.GYP_DEFINES = copy.deepcopy(self.__config['GYP_DEFINES'])
+      else:
+        cfg.gyp_env.GYP_DEFINES = dict(v.split('=') for
+                                       v in self.__config['GYP_DEFINES'])
     self.m.chromium.c = cfg
 
+    use_goma = (self.compiler == 'ninja' and
+                (cfg.gyp_env.GYP_DEFINES.get('goma') == '1' or
+                 'use_goma=true' in self.__config['gn_args']))
+    if use_goma:

[smut, 2016/07/07 22:58:28]

Do we need the "if 'without patch' not in suffix" condition? I think there was
some issue re-applying these configs for the without patch retry. Unless it's
fixed now to be idempotent.

[Dirk Pranke, 2016/07/07 23:05:36]

This block is moved from build() to read_build_config(). We needed 
the if-check in build() because it might get called twice, but we can 
only apply the configs once. However, read_build_config() is only 
called once, so we don't need the check.

I.e., this change is actually doing the refactor mentioned in the TODO, below.

+      # Make sure these chromium configs are applied consistently for the
+      # rest of the recipe.

[Dirk Pranke, 2016/07/07 23:05:36]

These are needed for m.chromium.compile() to work properly w/ goma+ninja. I will
update the comment to make that clearer.

+      self.m.chromium.apply_config('ninja')
+      self.m.chromium.apply_config('default_compiler')
+      self.m.chromium.apply_config('goma')
+
+      # Calling ensure_goma() after apply_config('goma') make sure that
+      # we gett the right c.compile_py.goma_dir .

[smut, 2016/07/07 22:58:28]

s/gett/get/

[Dirk Pranke, 2016/07/07 23:05:58]

Done.

+      self.m.chromium.ensure_goma()
+
   def build(self, mb_config_path=None, suffix=None):
     """Builds from this bot's build config."""
     assert self.__config is not None
 
     suffix = ' (%s)' % suffix if suffix else ''
 
     if self.using_mb:
       self.m.chromium.c.project_generator.tool = 'mb'
 
     # Add the default GYP_DEFINES.
@@ skipping 90 matching lines @@
           test['skip'] = True
 
       if compile_targets: # pragma: no cover
         cmd.extend(compile_targets)
       else:
         return
 
     use_goma = (self.compiler == 'ninja' and
                 ('use_goma=1' in gyp_defines or 'use_goma=true' in gn_args))
     if use_goma:
-      if 'without patch' not in suffix:
-        # TODO(crbug.com/603641):
-        # Configs aren't deapplied, so we only want to apply these
-        # configs once. Really, we should refactor this so that we're
-        # not applying configs at all in build(), but rather do it
-        # in an earlier step.
-        self.m.chromium.apply_config('ninja')
-        self.m.chromium.apply_config('default_compiler')
-        self.m.chromium.apply_config('goma')
       self.m.chromium.compile(targets=compile_targets,
                               target=build_sub_path,
                               cwd=cwd)
     else:
       self.m.step('compile' + suffix, cmd, cwd=cwd)
 
   def test(self, *args):
     """Runs tests as instructed by this bot's build config.
 
     Args:
@@ skipping 138 matching lines @@
         self.configuration,
         'iossim',
       ),
       'ninja': self.m.path.join(
         'src',
          build_dir,
          '%s-%s' % (self.configuration, platform),
          'iossim',
       ),
     }[self.compiler]