Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(765)

Issue 2133453002: [vinn] Update Windows d8 binary to 5.2.361.30 (Closed)

Created:
4 years, 5 months ago by charliea (OOO until 10-5)
Modified:
4 years, 5 months ago
Reviewers:
nednguyen
CC:
catapult-reviews_chromium.org
Base URL:
https://github.com/catapult-project/catapult.git@master
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

[vinn] Update Windows d8 binary to 5.2.361.30 TBR=nednguyen@google.com NOPRESUBMIT=true NOTRY=true BUG=catapult:#2458 Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/243e3dfbc911dba7d7ad2397aa5d975d6b85a854

Patch Set 1 #

Patch Set 2 : Merge branch 'master' of https://github.com/catapult-project/catapult into update_win_d8_binary2 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/vinn/third_party/v8/README.chromium View 1 chunk +1 line, -1 line 0 comments Download
M third_party/vinn/third_party/v8/win/AMD64/d8.exe View Binary file 0 comments Download
M third_party/vinn/third_party/v8/win/AMD64/icudt.dll View Binary file 0 comments Download

Messages

Total messages: 20 (10 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2133453002/1
4 years, 5 months ago (2016-07-07 21:32:01 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: Catapult Linux Tryserver on master.tryserver.client.catapult (JOB_FAILED, https://build.chromium.org/p/tryserver.client.catapult/builders/Catapult%20Linux%20Tryserver/builds/3859)
4 years, 5 months ago (2016-07-07 21:33:12 UTC) #6
charliea (OOO until 10-5)
(Had to add NOTRY and NOPRESUBMIT because it's not possible to submit binary files otherwise.)
4 years, 5 months ago (2016-07-07 21:37:57 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2133453002/1
4 years, 5 months ago (2016-07-07 21:38:12 UTC) #10
commit-bot: I haz the power
Failed to apply patch for third_party/vinn/third_party/v8/README.chromium: While running git apply --index -3 -p1; error: patch ...
4 years, 5 months ago (2016-07-07 21:38:17 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2133453002/20001
4 years, 5 months ago (2016-07-07 21:40:40 UTC) #14
commit-bot: I haz the power
Failed to apply patch for third_party/vinn/third_party/v8/README.chromium: While running git apply --index -3 -p1; error: patch ...
4 years, 5 months ago (2016-07-07 21:40:52 UTC) #16
charliea (OOO until 10-5)
Committed patchset #2 (id:20001) manually as 243e3dfbc911dba7d7ad2397aa5d975d6b85a854 (presubmit successful).
4 years, 5 months ago (2016-07-07 21:43:20 UTC) #18
charliea (OOO until 10-5)
Due to stupid merge failures, I had to land this manually. Still not sure exactly ...
4 years, 5 months ago (2016-07-07 21:43:43 UTC) #19
nednguyen
4 years, 5 months ago (2016-07-08 00:25:45 UTC) #20
Message was sent while issue was closed.
On 2016/07/07 21:43:43, charliea wrote:
> Due to stupid merge failures, I had to land this manually. Still not sure
> exactly what problem it was having with the merge, even after I synced to
head.

Oh, I think you have to always use "git cl land" for binary. The code review
tool never allows uploading binary.

Powered by Google App Engine
This is Rietveld 408576698