Don't print variable descriptors by default when printing disassembly.

Don't print variable descriptors by default when printing disassembly.

Since variable descriptors are generated lazily, printing disassembly
could trigger re-parsing. This should not hurt in general, but running with
--disassemble should not invoke the parser just for printing -- hereby triggering GC or otherwise altering the execution in unexpected ways.

BUG=#26441
R=rmacnak@google.com

Committed: https://github.com/dart-lang/sdk/commit/cbc1d9fc6315889fc94abcacdde3dbd68b419c99

[Florian Schneider, 2016-07-07 21:25:51]

Description was changed from

==========
Don't print variable descriptors by default when printing disassembly.

Since variable descriptors are generated lazily, printing disassembly
could trigger re-parsing. This should not hurt, but running with
--disassemble should not invoke the parser just for printing.

BUG=
==========

to

==========
Don't print variable descriptors by default when printing disassembly.

Since variable descriptors are generated lazily, printing disassembly
could trigger re-parsing. This should not hurt in general, but running with
--disassemble should not invoke the parser just for printing -- hereby
triggering GC or otherwise altering the execution in unexpected ways.

BUG=#26441
==========

[Florian Schneider, 2016-07-07 21:26:04]

fschneider@google.com changed reviewers:
+ rmacnak@google.com

[rmacnak, 2016-07-08 01:04:18]

lgtm

Please add a test analogous to disassemble_test that exercises the new flag.

[Florian Schneider, 2016-07-08 17:06:49]

On 2016/07/08 01:04:18, rmacnak wrote:
> lgtm
> 
> Please add a test analogous to disassemble_test that exercises the new flag.

Done.

[Florian Schneider, 2016-07-08 17:12:30]

Description was changed from

==========
Don't print variable descriptors by default when printing disassembly.

Since variable descriptors are generated lazily, printing disassembly
could trigger re-parsing. This should not hurt in general, but running with
--disassemble should not invoke the parser just for printing -- hereby
triggering GC or otherwise altering the execution in unexpected ways.

BUG=#26441
==========

to

==========
Don't print variable descriptors by default when printing disassembly.

Since variable descriptors are generated lazily, printing disassembly
could trigger re-parsing. This should not hurt in general, but running with
--disassemble should not invoke the parser just for printing -- hereby
triggering GC or otherwise altering the execution in unexpected ways.

BUG=#26441
R=rmacnak@google.com

Committed:
https://github.com/dart-lang/sdk/commit/cbc1d9fc6315889fc94abcacdde3dbd68b419c99
==========

[Florian Schneider, 2016-07-08 17:12:31]

Committed patchset #2 (id:20001) manually as
cbc1d9fc6315889fc94abcacdde3dbd68b419c99 (presubmit successful).