Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(318)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 213343002: Remove traces of beforeload in HTMLMediaElement (Closed)

Created:
6 years, 9 months ago by philipj_slow
Modified:
6 years, 9 months ago
CC:
blink-reviews, nessy, philipj_slow, gasubic, fs, eric.carlson_apple.com, feature-media-reviews_chromium.org, dglazkov+blink, adamk+blink_chromium.org, vcarbune.chromium
Visibility:
Public.

Description

Remove traces of beforeload in HTMLMediaElement There now remain no places in HTMLMediaElement where events are dispatched synchronously, so there's no need to protect(this). For the same reason, the ASSERT is irrelevant, even if it holds true. BUG=none Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170123

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -7 lines) Patch
M Source/core/html/HTMLMediaElement.cpp View 3 chunks +0 lines, -7 lines 0 comments Download

Messages

Total messages: 17 (0 generated)
philipj_slow
6 years, 9 months ago (2014-03-26 17:43:02 UTC) #1
acolwell GONE FROM CHROMIUM
lgtm
6 years, 9 months ago (2014-03-26 17:50:12 UTC) #2
philipj_slow
The CQ bit was checked by philipj@opera.com
6 years, 9 months ago (2014-03-26 17:58:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/213343002/1
6 years, 9 months ago (2014-03-26 17:58:26 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-26 18:24:22 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on win_blink_rel
6 years, 9 months ago (2014-03-26 18:24:22 UTC) #6
philipj_slow
The CQ bit was checked by philipj@opera.com
6 years, 9 months ago (2014-03-26 18:27:00 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/213343002/1
6 years, 9 months ago (2014-03-26 18:27:01 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-26 19:42:14 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on win_blink_rel
6 years, 9 months ago (2014-03-26 19:42:15 UTC) #10
philipj_slow
The CQ bit was checked by philipj@opera.com
6 years, 9 months ago (2014-03-27 01:35:08 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/213343002/1
6 years, 9 months ago (2014-03-27 01:35:17 UTC) #12
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-27 02:14:15 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on win_blink_rel
6 years, 9 months ago (2014-03-27 02:14:15 UTC) #14
philipj_slow
The CQ bit was checked by philipj@opera.com
6 years, 9 months ago (2014-03-27 02:16:56 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/213343002/1
6 years, 9 months ago (2014-03-27 02:17:04 UTC) #16
commit-bot: I haz the power
6 years, 9 months ago (2014-03-27 02:48:18 UTC) #17
Message was sent while issue was closed. 
Change committed as 170123

Powered by Google App Engine
This is Rietveld 408576698