Issue 21334002: Revert 214160 "Implement Worker-MainThread bridge for FileSystem..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 21334002: Revert 214160 "Implement Worker-MainThread bridge for FileSystem..." (Closed)

Created:
7 years, 4 months ago by kinuko

Modified:
7 years, 4 months ago

Reviewers:
kinuko

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/

Visibility:
Public.

Revert 214160 "Implement Worker-MainThread bridge for FileSystem..." Suspected to have performance regression, let's see if this changes anything BUG=265658 > Implement Worker-MainThread bridge for FileSystem API in Chrome > > This basically adds the same worker/mainThread bridge functionality > for FileSystem API in Chrome side. > > Keeping bridge code around is suboptimal, but this allows us to remove > bridge code in Blink side which in turn allows us to make further > worker-related cleanups in Blink. > > This change doesn't contain FileWriter related changes yet. > (For reference, combined patch is uploaded here: > https://codereview.chromium.org/19287010/) > > BUG=257349 > TEST=no behavioral changes yet > R=atwilson@chromium.org, jochen@chromium.org, michaeln@chromium.org, tzik@chromium.org > > Review URL: https://codereview.chromium.org/19387002 TBR=kinuko@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=214599

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+141 lines, -338 lines)			Patch
M	trunk/src/content/child/fileapi/file_system_dispatcher.h	View	2 chunks	+1 line, -5 lines	0 comments	Download
M	trunk/src/content/child/fileapi/file_system_dispatcher.cc	View	3 chunks	+5 lines, -5 lines	0 comments	Download
MM	trunk/src/content/child/fileapi/webfilesystem_callback_adapters.h	View	1 chunk	+14 lines, -0 lines	0 comments	Download
MM	trunk/src/content/child/fileapi/webfilesystem_callback_adapters.cc	View	1 chunk	+31 lines, -0 lines	0 comments	Download
MM	trunk/src/content/child/fileapi/webfilesystem_impl.h	View	3 chunks	+2 lines, -10 lines	0 comments	Download
MM	trunk/src/content/child/fileapi/webfilesystem_impl.cc	View	5 chunks	+86 lines, -316 lines	0 comments	Download
MM	trunk/src/content/renderer/renderer_webkitplatformsupport_impl.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
MM	trunk/src/content/worker/worker_webkitplatformsupport_impl.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 2 (0 generated)

Message was sent while issue was closed.

Committed patchset #1 manually as r214599.