Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1685)

Unified Diff: ash/common/wm/overview/window_selector.cc

Issue 2133333002: [ash-md] Allows docked windows to be selected in overview mode (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: [ash-md] Allows docked windows to be selected in overview mode (comments + tests) Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ash/common/wm/overview/window_selector.cc
diff --git a/ash/common/wm/overview/window_selector.cc b/ash/common/wm/overview/window_selector.cc
index 3263411e7a0c8570a2d6e6cc649fd9be1bccd8df..73906fac466b9c3b79d52f813d25180ab711cc41 100644
--- a/ash/common/wm/overview/window_selector.cc
+++ b/ash/common/wm/overview/window_selector.cc
@@ -264,8 +264,9 @@ views::Widget* CreateTextFilter(views::TextfieldController* controller,
// static
bool WindowSelector::IsSelectable(WmWindow* window) {
wm::WindowState* state = window->GetWindowState();
- if (state->GetStateType() == wm::WINDOW_STATE_TYPE_DOCKED ||
- state->GetStateType() == wm::WINDOW_STATE_TYPE_DOCKED_MINIMIZED) {
+ if (!ash::MaterialDesignController::IsOverviewMaterial() &&
+ (state->GetStateType() == wm::WINDOW_STATE_TYPE_DOCKED ||
+ state->GetStateType() == wm::WINDOW_STATE_TYPE_DOCKED_MINIMIZED)) {
return false;
}
return state->IsUserPositionable();
@@ -379,6 +380,14 @@ void WindowSelector::Init(const WindowList& windows) {
// may cause other, unrelated classes, (ie PanelLayoutManager) to make indirect
// calls to restoring_minimized_windows() on a partially destructed object.
void WindowSelector::Shutdown() {
+ size_t remaining_items = 0;
+ for (std::unique_ptr<WindowGrid>& window_grid : grid_list_) {
+ for (WindowSelectorItem* window_selector_item : window_grid->window_list())
+ window_selector_item->RestoreWindow();
+ remaining_items += window_grid->size();
+ }
+
+ // Setting focus after restoring windows' state avoids unnecessary animations.
ResetFocusRestoreWindow(true);
RemoveAllObservers();
@@ -389,13 +398,6 @@ void WindowSelector::Shutdown() {
PanelLayoutManager::Get(window)->SetShowCalloutWidgets(true);
}
- size_t remaining_items = 0;
- for (std::unique_ptr<WindowGrid>& window_grid : grid_list_) {
- for (WindowSelectorItem* window_selector_item : window_grid->window_list())
- window_selector_item->RestoreWindow();
- remaining_items += window_grid->size();
- }
-
DCHECK(num_items_ >= remaining_items);
UMA_HISTOGRAM_COUNTS_100("Ash.WindowSelector.OverviewClosedItems",
num_items_ - remaining_items);
« no previous file with comments | « ash/common/wm/overview/scoped_transform_overview_window.cc ('k') | ash/wm/overview/window_selector_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698