Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Unified Diff: ash/common/wm/overview/scoped_transform_overview_window.h

Issue 2133333002: [ash-md] Allows docked windows to be selected in overview mode (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: [ash-md] Allows docked windows to be selected in overview mode (comments + tests) Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ash/common/wm/overview/scoped_transform_overview_window.h
diff --git a/ash/common/wm/overview/scoped_transform_overview_window.h b/ash/common/wm/overview/scoped_transform_overview_window.h
index adf25f203f5157ca27fa5ead215d7f4f5d5a7f03..a32974ad2824d9b24151835cdf14f6ea5001b1ea 100644
--- a/ash/common/wm/overview/scoped_transform_overview_window.h
+++ b/ash/common/wm/overview/scoped_transform_overview_window.h
@@ -122,6 +122,12 @@ class ASH_EXPORT ScopedTransformOverviewWindow {
friend class WindowSelectorTest;
class OverviewContentMask;
+ enum OriginalVisibility {
+ ORIGINALLY_VISIBLE,
+ ORIGINALLY_MINIMIZED,
+ ORIGINALLY_DOCKED_MINIMIZED,
+ };
+
// Shows the window if it was minimized.
void ShowWindowIfMinimized();
@@ -144,9 +150,9 @@ class ASH_EXPORT ScopedTransformOverviewWindow {
// been determined that window shape was not originally set on the |window_|.
bool determined_original_window_shape_;
- // If true, the window was minimized and should be restored if the window
- // was not selected.
- bool minimized_;
+ // Original visibility of |window_| upon entering overview mode that needs to
+ // be restored unless the window gets selected.
+ OriginalVisibility original_visibility_;
// Tracks if this window was ignored by the shelf.
bool ignored_by_shelf_;
« no previous file with comments | « ash/common/wm/dock/docked_window_layout_manager.cc ('k') | ash/common/wm/overview/scoped_transform_overview_window.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698