Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 2133313002: Disables some CRWWebController tests on iOS 10. (Closed)

Created:
4 years, 5 months ago by rohitrao (ping after 24h)
Modified:
4 years, 5 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disables some CRWWebController tests on iOS 10. BUG=626688 Committed: https://crrev.com/9ebc13a375d86231d06efbf449f19f2172e51f24 Cr-Commit-Position: refs/heads/master@{#404531}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Review. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M ios/web/web_state/ui/crw_web_controller_unittest.mm View 1 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
rohitrao (ping after 24h)
4 years, 5 months ago (2016-07-08 20:38:20 UTC) #2
Eugene But (OOO till 7-30)
lgtm, could you please use 2 separate bugs for these failures. The reason for failures ...
4 years, 5 months ago (2016-07-08 20:40:18 UTC) #5
Eugene But (OOO till 7-30)
https://codereview.chromium.org/2133313002/diff/1/ios/web/web_state/ui/crw_web_controller_unittest.mm File ios/web/web_state/ui/crw_web_controller_unittest.mm (right): https://codereview.chromium.org/2133313002/diff/1/ios/web/web_state/ui/crw_web_controller_unittest.mm#newcode766 ios/web/web_state/ui/crw_web_controller_unittest.mm:766: // TODO(crbug.com/626688): Figure out why this test is hanging ...
4 years, 5 months ago (2016-07-08 21:14:35 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2133313002/20001
4 years, 5 months ago (2016-07-08 22:53:18 UTC) #11
rohitrao (ping after 24h)
https://codereview.chromium.org/2133313002/diff/1/ios/web/web_state/ui/crw_web_controller_unittest.mm File ios/web/web_state/ui/crw_web_controller_unittest.mm (right): https://codereview.chromium.org/2133313002/diff/1/ios/web/web_state/ui/crw_web_controller_unittest.mm#newcode766 ios/web/web_state/ui/crw_web_controller_unittest.mm:766: // TODO(crbug.com/626688): Figure out why this test is hanging ...
4 years, 5 months ago (2016-07-08 22:53:32 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-08 23:27:58 UTC) #13
commit-bot: I haz the power
4 years, 5 months ago (2016-07-08 23:30:08 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/9ebc13a375d86231d06efbf449f19f2172e51f24
Cr-Commit-Position: refs/heads/master@{#404531}

Powered by Google App Engine
This is Rietveld 408576698