Gate Android drag and drop feature with a flag.

Gate Android drag and drop feature with a flag.

We want to fully test it before enabling by default.

BUG=626773
Committed: https://crrev.com/29ec4189153a39f8730991f727f58aa4dae7fe35
Cr-Commit-Position: refs/heads/master@{#404540}

[hush (inactive), 2016-07-08 20:10:22]

Description was changed from

==========
Gate Android drag and drop feature with a flag.

BUG=584789
==========

to

==========
Gate Android drag and drop feature with a flag.

We want to fully test it before enabling by default.

BUG=584789
==========

[hush (inactive), 2016-07-08 20:34:27]

Description was changed from

==========
Gate Android drag and drop feature with a flag.

We want to fully test it before enabling by default.

BUG=584789
==========

to

==========
Gate Android drag and drop feature with a flag.

We want to fully test it before enabling by default.

BUG=626773
==========

[hush (inactive), 2016-07-08 20:35:00]

hush@chromium.org changed reviewers:
+ yfriedman@chromium.org

[hush (inactive), 2016-07-08 20:35:00]

Hello Yaron, PTAL

[Yaron, 2016-07-08 21:22:18]

lgtm

https://codereview.chromium.org/2133303002/diff/1/content/public/android/java...
File
content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java
(right):

https://codereview.chromium.org/2133303002/diff/1/content/public/android/java...
content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java:3285:
public boolean onDragEvent(DragEvent event) {
does this fire a lot as you drag your finger around? if so, you may consider
caching it to avoid jni hop?

[hush (inactive), 2016-07-08 21:53:06]

https://codereview.chromium.org/2133303002/diff/1/content/public/android/java...
File
content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java
(right):

https://codereview.chromium.org/2133303002/diff/1/content/public/android/java...
content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java:3285:
public boolean onDragEvent(DragEvent event) {
On 2016/07/08 21:22:18, Yaron wrote:
> does this fire a lot as you drag your finger around? if so, you may consider
> caching it to avoid jni hop?

In fact, if I return false in DragEvent.ACTION_DRAG_STARTED, I won't receive
subsequent DragEvents, because I expressed my disinterest in the dragevent to
the platform already.

So what I could do instead is only checking the flag at ACTION_DRAG_STARTED.

[hush (inactive), 2016-07-08 22:40:44]

The CQ bit was checked by hush@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-08 22:41:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-08 23:46:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-08 23:46:45]

Dry run: This issue passed the CQ dry run.

[hush (inactive), 2016-07-08 23:58:10]

The CQ bit was checked by hush@chromium.org

[hush (inactive), 2016-07-08 23:58:10]

The patchset sent to the CQ was uploaded after l-g-t-m from
yfriedman@chromium.org
Link to the patchset: https://codereview.chromium.org/2133303002/#ps20001
(title: "Less JNI calls")

[commit-bot: I haz the power, 2016-07-08 23:58:44]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-09 00:03:29]

Description was changed from

==========
Gate Android drag and drop feature with a flag.

We want to fully test it before enabling by default.

BUG=626773
==========

to

==========
Gate Android drag and drop feature with a flag.

We want to fully test it before enabling by default.

BUG=626773
==========

[commit-bot: I haz the power, 2016-07-09 00:03:30]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-07-09 00:03:37]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-09 00:06:22]

Description was changed from

==========
Gate Android drag and drop feature with a flag.

We want to fully test it before enabling by default.

BUG=626773
==========

to

==========
Gate Android drag and drop feature with a flag.

We want to fully test it before enabling by default.

BUG=626773

Committed: https://crrev.com/29ec4189153a39f8730991f727f58aa4dae7fe35
Cr-Commit-Position: refs/heads/master@{#404540}
==========

[commit-bot: I haz the power, 2016-07-09 00:06:23]

Patchset 2 (id:??) landed as
https://crrev.com/29ec4189153a39f8730991f727f58aa4dae7fe35
Cr-Commit-Position: refs/heads/master@{#404540}