Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(879)

Issue 2133233003: VideoCaptureDeviceTest: s/MockClient/MockVideoCaptureClient/ and s/client_/video_capture_client_/ (Closed)

Created:
4 years, 5 months ago by mcasas
Modified:
4 years, 5 months ago
Reviewers:
emircan
CC:
chromium-reviews, posciak+watch_chromium.org, feature-media-reviews_chromium.org, mcasas+watch+vc_chromium.org, miu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

VideoCaptureDeviceTest: s/MockClient/MockVideoCaptureClient/ and s/client_/video_capture_client_/ * No new code introduced whatsoever * Like it says in the title: s/MockClient/MockVideoCaptureClient/ and s/client_/video_capture_client_/ because there's a new client coming in https://crrev.com/2129733004, (namely MockImageCaptureClient), now we have to specify. TEST=capture_unittests passing merrily as before. TBR=emircan@chromium.org (since this CL is trivial) Committed: https://crrev.com/265ff8b62c9071a96858a87a428caf0599de0edc Cr-Commit-Position: refs/heads/master@{#404462}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -22 lines) Patch
M media/capture/video/video_capture_device_unittest.cc View 13 chunks +24 lines, -22 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2133233003/1
4 years, 5 months ago (2016-07-08 18:11:50 UTC) #3
emircan
lgtm
4 years, 5 months ago (2016-07-08 18:20:45 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-08 19:33:14 UTC) #7
commit-bot: I haz the power
4 years, 5 months ago (2016-07-08 19:34:43 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/265ff8b62c9071a96858a87a428caf0599de0edc
Cr-Commit-Position: refs/heads/master@{#404462}

Powered by Google App Engine
This is Rietveld 408576698