[LoadIC] Handle simple field loads in the dispatcher

[LoadIC] Handle simple field loads in the dispatcher

No compiled handlers required! Instead, the type feedback vector
contains a Smi encoding the field index.

Committed: https://crrev.com/9c59539f2730d535f3489e4a68f6982b926f7ae0
Cr-Commit-Position: refs/heads/master@{#37803}

[Jakob Kummerow, 2016-07-13 17:27:35]

The CQ bit was checked by jkummerow@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-13 17:27:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-13 17:30:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-13 17:30:30]

Dry run: Try jobs failed on following builders:
  v8_linux_mipsel_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mipsel_compile_rel...)

[Jakob Kummerow, 2016-07-14 13:46:33]

jkummerow@chromium.org changed reviewers:
+ ishell@chromium.org

[Jakob Kummerow, 2016-07-14 13:46:33]

PTAL.

[Igor Sheludko, 2016-07-15 10:44:18]

lgtm!

https://codereview.chromium.org/2133233002/diff/40001/src/ic/ic.cc
File src/ic/ic.cc (right):

https://codereview.chromium.org/2133233002/diff/40001/src/ic/ic.cc#newcode688
src/ic/ic.cc:688: if (!(code->IsSmi() ||
It is hard to understand this "if". How about:

DCHECK(code->IsSmi() || code->IsCode());
if (!code->IsSmi() && !Code::cast(*code)->is_handler())) {
  return false;
}

https://codereview.chromium.org/2133233002/diff/40001/src/type-feedback-vecto...
File src/type-feedback-vector.cc (right):

https://codereview.chromium.org/2133233002/diff/40001/src/type-feedback-vecto...
src/type-feedback-vector.cc:832: (object->IsCode() && Code::cast(object)->kind()
== Code::HANDLER);
... && Code::cast(object)->is_handler());

[Jakob Kummerow, 2016-07-15 14:16:42]

Thanks, comments addressed, landing.

https://codereview.chromium.org/2133233002/diff/40001/src/ic/ic.cc
File src/ic/ic.cc (right):

https://codereview.chromium.org/2133233002/diff/40001/src/ic/ic.cc#newcode688
src/ic/ic.cc:688: if (!(code->IsSmi() ||
On 2016/07/15 10:44:18, Igor Sheludko wrote:
> It is hard to understand this "if". How about:
> 
> DCHECK(code->IsSmi() || code->IsCode());
> if (!code->IsSmi() && !Code::cast(*code)->is_handler())) {
>   return false;
> }

Done.

https://codereview.chromium.org/2133233002/diff/40001/src/type-feedback-vecto...
File src/type-feedback-vector.cc (right):

https://codereview.chromium.org/2133233002/diff/40001/src/type-feedback-vecto...
src/type-feedback-vector.cc:832: (object->IsCode() && Code::cast(object)->kind()
== Code::HANDLER);
On 2016/07/15 10:44:18, Igor Sheludko wrote:
> ... && Code::cast(object)->is_handler());

Done.

[Jakob Kummerow, 2016-07-15 14:16:47]

The CQ bit was checked by jkummerow@chromium.org

[Jakob Kummerow, 2016-07-15 14:16:48]

The patchset sent to the CQ was uploaded after l-g-t-m from ishell@chromium.org
Link to the patchset: https://codereview.chromium.org/2133233002/#ps80001
(title: "rebased")

[commit-bot: I haz the power, 2016-07-15 14:16:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-15 14:19:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-15 14:19:46]

Try jobs failed on following builders:
  v8_linux_mips64el_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mips64el_compile_r...)

[Jakob Kummerow, 2016-07-15 15:49:23]

The CQ bit was checked by jkummerow@chromium.org

[Jakob Kummerow, 2016-07-15 15:49:23]

The patchset sent to the CQ was uploaded after l-g-t-m from ishell@chromium.org
Link to the patchset: https://codereview.chromium.org/2133233002/#ps100001
(title: "fix release builds for realz")

[commit-bot: I haz the power, 2016-07-15 15:49:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-15 17:41:24]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-07-15 17:44:38]

Description was changed from

==========
[LoadIC] Handle simple field loads in the dispatcher

No compiled handlers required! Instead, the type feedback vector
contains a Smi encoding the field index.
==========

to

==========
[LoadIC] Handle simple field loads in the dispatcher

No compiled handlers required! Instead, the type feedback vector
contains a Smi encoding the field index.

Committed: https://crrev.com/9c59539f2730d535f3489e4a68f6982b926f7ae0
Cr-Commit-Position: refs/heads/master@{#37803}
==========

[commit-bot: I haz the power, 2016-07-15 17:44:39]

Patchset 6 (id:??) landed as
https://crrev.com/9c59539f2730d535f3489e4a68f6982b926f7ae0
Cr-Commit-Position: refs/heads/master@{#37803}