Convert video-played* tests to testharness.js

third_party/WebKit/LayoutTests/media/video-played.js

-
 var expectedStartTimes = new Array();

[fs, 2016/07/12 18:04:24]

Could we try making this not use random state on the global object? (I.e prefer
passing arguments to the "helpers" instead.)

[Srirama, 2016/07/13 18:48:32]

Done, assuming that you are talking about the array objects. Or do you want me
to try and remove other globals also? Javascript doesn't support
pass-by-reference variables, so "timeRangeCount" cannot be passed.

[fs, 2016/07/15 19:36:48]

Well, preferably all globals in the "helper" script. Constructing the "expected"
array(s) could move to the tests themselves hopefully. Maybe we could migrate
this piecemeal though?

 var expectedEndTimes = new Array();
 var timeRangeCount = 0;
 var currentTimeRange = 0;
-var currentTest = 0;
-var willPauseInExistingRange = false;
-var willExtendAnExistingRange = false;
+var playDuration = 0;
+var startTimeOfPlay = 0;
+var startTime = 0;
 
-var testStartTime = 0;
-var logTestTiming = false;
+function testRanges() {
+    assert_equals(video.played.length, timeRangeCount);
 
-//@@@@@ Uncomment the following line to log the time each "video-played" sub-test takes in test output
-//@@@@@ logTestTiming = true;
-
-function logRanges()
-{
-    consoleWrite("");
     for (i = 0; i < timeRangeCount; i++) {
-        consoleWrite("****  range " + i + " ( " + video.played.start(i).toFixed(2) + ".." + video.played.end(i).toFixed(2) + ")");
+        assert_equals(video.played.start(i).toFixed(2), expectedStartTimes[i]);
+        assert_equals(video.played.end(i).toFixed(2), expectedEndTimes[i]);
     }
 }
 
-function testRanges()
-{
-    if (testStartTime) {
-        logRanges();
-
-        var duration = (window.performance.now() - testStartTime) / 1000;
-        consoleWrite("**** Test " + currentTest + " took " + duration.toFixed(2) + " seconds");
-    }
-
-    testExpected("video.played.length", timeRangeCount);
-
-    for (i = 0; i < timeRangeCount; i++) {
-        testExpected("video.played.start(" + (i) + ").toFixed(2)", expectedStartTimes[i]);
-        testExpected("video.played.end("   + (i) + ").toFixed(2)", expectedEndTimes[i]);
-    }
+function waitForPauseAndContinue(t, nextFunc, extendsRange) {
+    video.onpause = t.step_func(function() {
+        var currentTime = video.currentTime.toFixed(2);
+        if (extendsRange) {
+            if(expectedEndTimes[currentTimeRange] < currentTime
+                || expectedEndTimes[currentTimeRange] == undefined) {
+                expectedEndTimes[currentTimeRange] = currentTime;
+            }
+        } else {
+            expectedEndTimes.splice(currentTimeRange, 0, currentTime);
+        }
+        testRanges();
+        if (nextFunc)
+            nextFunc();
+        else
+            t.done();
+    });
 }
-
-function nextTest()
-{
-    if (logTestTiming)
-        testStartTime = window.performance.now();
-
-    if (currentTest >= testFunctions.length)
-        endTest();
-    else
-        (testFunctions[currentTest])();
-    currentTest++;
-}
-
-function pause(evt)
-{
-    currentTime = video.currentTime.toFixed(2);
-
-    if (!willExtendAnExistingRange)
-        expectedEndTimes.splice(currentTimeRange, 0, currentTime)
-        else if(expectedEndTimes[currentTimeRange] < currentTime || expectedEndTimes[currentTimeRange] == undefined)
-            expectedEndTimes[currentTimeRange] = currentTime;
-
-    testRanges();
-    nextTest();
-}
-
-function canplay(event)
-{
-    testRanges();
-    nextTest();
-}
-
-function willCreateNewRange()
-{
+function willCreateNewRange() {
     expectedStartTimes.splice(currentTimeRange, 0, video.currentTime.toFixed(2))
     ++timeRangeCount;
 }
 
-function startPlayingInNewRange()
-{
-    willCreateNewRange();
-    startPlaying();
+function callPauseIfTimeIsReached() {
+    var playedTime = video.currentTime - startTimeOfPlay;
+    if (playedTime < 0) {
+        // Deal with "loop" attribute. This allows only one loop, hence the first warning
+        // at the begining of platForDuration().
+        playedTime = video.duration - startTimeOfPlay + video.currentTime;
+    }
+
+    var elapsed = (performance.now() / 1000) - startTime;
+    assert_less_than_equal(elapsed, 3.0);
+    if (playedTime >= playDuration || video.currentTime == video.duration)
+        video.pause();
+    else {
+        var delta = (playDuration - playedTime)  * 1000;
+        setTimeout(this.step_func(callPauseIfTimeIsReached), delta);
+    }
 }
 
-function startPlaying()
-{
-    playForMillisecs(100); // Triggers pause()
+function playForDuration(duration, t) {
+    playDuration = duration;
+    assert_less_than_equal(playDuration, video.duration);
+
+    // A 2 second timeout was sometimes insufficient to play 1.25 seconds of movie,
+    // though more than 1 second of movie typically had played prior to those failures.
+    // Use a larger value than 2 here.
+    var timeoutThreshold = 3.0;
+    assert_greater_than_equal(video.duration, timeoutThreshold);
+    assert_less_than_equal(playDuration, timeoutThreshold - 1.5);
+    video.play();
+    startTime = performance.now() / 1000;
+    startTimeOfPlay = video.currentTime;
+
+    // Add a small amount to the timer because it will take a non-zero
+    // amount of time for the video to start playing.
+    setTimeout(t.step_func(callPauseIfTimeIsReached), (duration * 1000) + 100);
 }
 
-function secToMilli(seconds)
-{
-    return seconds * 1000.;
+function startPlayingInNewRange(t) {
+    willCreateNewRange();
+    playForDuration(0.1, t);
 }
-
-function milliToSecs(milliseconds)
-{
-    return milliseconds / 1000;
-}
-
-function nowInSecs()
-{
-    return milliToSecs(window.performance.now());
-}
-
-function playForMillisecs(milliseconds)
-{
-    var playDuration = milliToSecs(milliseconds);
-    if (playDuration > video.duration) {
-        failTest("WARNING: playForMillisecs() does not support range (" + playDuration + ") bigger than video duration (" + video.duration + ") (yet)");
-        return;
-    }
-
-    // A 2 second timeout was sometimes insufficient to play 1.25 seconds of movie, though more
-    // than 1 second of movie typically had played prior to those failures. Use a larger value
-    // than 2 here.
-    var timeoutThreshold = 3.;
-
-    if (video.duration < timeoutThreshold) {
-        failTest("WARNING: playForMillisecs() does not support video duration(" + video.duration + ") smaller than timeout threshold (" + timeoutThreshold + ")");
-        return;
-    }
-
-    if (playDuration > timeoutThreshold - 1.5) {
-        failTest("WARNING: playForMillisecs() does not support range (" + playDuration + ") within 1.5 seconds of timeout threshold (" + timeoutThreshold + ")");
-        return;
-    }
-
-    run("video.play()");
-
-    var startTime = nowInSecs();
-    var playedFromTime = video.currentTime;
-    var callPauseIfTimeIsReached = function ()
-    {
-        var playedTime = video.currentTime - playedFromTime;
-
-        if (playedTime < 0) {
-            // Deal with 'loop' attribute. This allows only one loop, hence the first warning
-            // at the begining of playForMillisecs().
-            playedTime = video.duration - playedFromTime + video.currentTime;
-        }
-
-        var elapsed = nowInSecs() - startTime;
-        if (elapsed > timeoutThreshold) {
-            // Just in case something goes wrong.
-            failTest("ERROR: test stalled, waited " + elapsed + " seconds for movie to play " + playedTime + " seconds");
-            return;
-        }
-
-        if (playedTime >= playDuration || video.currentTime == video.duration)
-            run("video.pause()");
-        else {
-            var delta = milliseconds - playedTime  * 1000;
-            setTimeout(callPauseIfTimeIsReached, delta);
-        }
-    }
-
-    // Add a small amount to the timer because it will take a non-zero amount of time for the 
-    // video to start playing.
-    setTimeout(callPauseIfTimeIsReached, milliseconds + 100);
-}
-
-function videoPlayedMain()
-{
-    findMediaElement();
-
-    video.src = findMediaFile("video", "content/test");
-
-    waitForEvent("error");
-    waitForEvent("loadstart");
-    waitForEvent("ratechange");
-    waitForEvent("loadedmetadata");
-    waitForEventOnce("canplay", canplay); // Will trigger nextTest() which launches the tests.
-    waitForEvent("pause", pause);
-
-    video.load();
-}