Convert video-played* tests to testharness.js

Convert video-played* tests to testharness.js

Cleaning up video-played* tests in media/
to use testharness.js instead of video-test.js.
This will enable to upstream these tests to web-platform-tests.

BUG=588956
Committed: https://crrev.com/ee06edf73261ca3c1682abad694a8a357e717a1a
Cr-Commit-Position: refs/heads/master@{#405957}

[Srirama, 2016-07-09 10:51:08]

Description was changed from

==========
fix

BUG=
==========

to

==========
Convert video-played* tests to testharness.js

Cleaning up video-played* tests in media/
to use testharness.js instead of video-test.js.
This will enable to upstream these tests to web-platform-tests.

BUG=588956
==========

[Srirama, 2016-07-09 10:56:16]

Patchset #1 (id:1) has been deleted

[Srirama, 2016-07-09 11:23:48]

Patchset #1 (id:20001) has been deleted

[Srirama, 2016-07-09 11:24:12]

srirama.m@samsung.com changed reviewers:
+ foolip@chromium.org, fs@opera.com

[Srirama, 2016-07-09 11:24:13]

PTAL

[fs, 2016-07-12 18:04:24]

https://codereview.chromium.org/2133223004/diff/40001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/media/video-played.js (right):

https://codereview.chromium.org/2133223004/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/media/video-played.js:1: var expectedStartTimes =
new Array();
Could we try making this not use random state on the global object? (I.e prefer
passing arguments to the "helpers" instead.)

[Srirama, 2016-07-13 18:48:32]

https://codereview.chromium.org/2133223004/diff/40001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/media/video-played.js (right):

https://codereview.chromium.org/2133223004/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/media/video-played.js:1: var expectedStartTimes =
new Array();
On 2016/07/12 18:04:24, fs (ooo to July 18) wrote:
> Could we try making this not use random state on the global object? (I.e
prefer
> passing arguments to the "helpers" instead.)

Done, assuming that you are talking about the array objects. Or do you want me
to try and remove other globals also? Javascript doesn't support
pass-by-reference variables, so "timeRangeCount" cannot be passed.

[fs, 2016-07-15 19:36:48]

https://codereview.chromium.org/2133223004/diff/40001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/media/video-played.js (right):

https://codereview.chromium.org/2133223004/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/media/video-played.js:1: var expectedStartTimes =
new Array();
On 2016/07/13 at 18:48:32, Srirama wrote:
> On 2016/07/12 18:04:24, fs (ooo to July 18) wrote:
> > Could we try making this not use random state on the global object? (I.e
prefer
> > passing arguments to the "helpers" instead.)
> 
> Done, assuming that you are talking about the array objects. Or do you want me
to try and remove other globals also? Javascript doesn't support
pass-by-reference variables, so "timeRangeCount" cannot be passed.

Well, preferably all globals in the "helper" script. Constructing the "expected"
array(s) could move to the tests themselves hopefully. Maybe we could migrate
this piecemeal though?

[Srirama, 2016-07-16 07:12:06]

On 2016/07/15 19:36:48, fs (ooo to July 18) wrote:
>
https://codereview.chromium.org/2133223004/diff/40001/third_party/WebKit/Layo...
> File third_party/WebKit/LayoutTests/media/video-played.js (right):
> 
>
https://codereview.chromium.org/2133223004/diff/40001/third_party/WebKit/Layo...
> third_party/WebKit/LayoutTests/media/video-played.js:1: var expectedStartTimes
=
> new Array();
> On 2016/07/13 at 18:48:32, Srirama wrote:
> > On 2016/07/12 18:04:24, fs (ooo to July 18) wrote:
> > > Could we try making this not use random state on the global object? (I.e
> prefer
> > > passing arguments to the "helpers" instead.)
> > 
> > Done, assuming that you are talking about the array objects. Or do you want
me
> to try and remove other globals also? Javascript doesn't support
> pass-by-reference variables, so "timeRangeCount" cannot be passed.
> 
> Well, preferably all globals in the "helper" script. Constructing the
"expected"
> array(s) could move to the tests themselves hopefully. Maybe we could migrate
> this piecemeal though?

Ok, if the current form is good enough then i will add a TODO and land it
first.wdyt?

[fs, 2016-07-16 13:28:13]

On 2016/07/16 at 07:12:06, srirama.m wrote:
> On 2016/07/15 19:36:48, fs (ooo to July 18) wrote:
...
> > Well, preferably all globals in the "helper" script. Constructing the
"expected"
> > array(s) could move to the tests themselves hopefully. Maybe we could
migrate
> > this piecemeal though?
> 
> Ok, if the current form is good enough then i will add a TODO and land it
first.wdyt?

Sounds good. LGTM w/ TODO.

https://codereview.chromium.org/2133223004/diff/60001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/media/video-played-reset.html (right):

https://codereview.chromium.org/2133223004/diff/60001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/media/video-played-reset.html:43: function
ResetToAnEmptyVideoSource() {
Nit: Maybe use lowercase 'r' here too.

[Srirama, 2016-07-17 16:57:39]

Patchset #3 (id:80001) has been deleted

[Srirama, 2016-07-17 17:00:34]

https://codereview.chromium.org/2133223004/diff/60001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/media/video-played-reset.html (right):

https://codereview.chromium.org/2133223004/diff/60001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/media/video-played-reset.html:43: function
ResetToAnEmptyVideoSource() {
On 2016/07/16 13:28:13, fs (ooo to July 18) wrote:
> Nit: Maybe use lowercase 'r' here too.

Done.

[Srirama, 2016-07-17 17:00:44]

The CQ bit was checked by srirama.m@samsung.com

[Srirama, 2016-07-17 17:00:45]

The patchset sent to the CQ was uploaded after l-g-t-m from fs@opera.com
Link to the patchset: https://codereview.chromium.org/2133223004/#ps100001
(title: "address nit, add TODO")

[commit-bot: I haz the power, 2016-07-17 17:00:55]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-17 18:41:39]

Description was changed from

==========
Convert video-played* tests to testharness.js

Cleaning up video-played* tests in media/
to use testharness.js instead of video-test.js.
This will enable to upstream these tests to web-platform-tests.

BUG=588956
==========

to

==========
Convert video-played* tests to testharness.js

Cleaning up video-played* tests in media/
to use testharness.js instead of video-test.js.
This will enable to upstream these tests to web-platform-tests.

BUG=588956
==========

[commit-bot: I haz the power, 2016-07-17 18:41:43]

Committed patchset #3 (id:100001)

[commit-bot: I haz the power, 2016-07-17 18:42:51]

Description was changed from

==========
Convert video-played* tests to testharness.js

Cleaning up video-played* tests in media/
to use testharness.js instead of video-test.js.
This will enable to upstream these tests to web-platform-tests.

BUG=588956
==========

to

==========
Convert video-played* tests to testharness.js

Cleaning up video-played* tests in media/
to use testharness.js instead of video-test.js.
This will enable to upstream these tests to web-platform-tests.

BUG=588956

Committed: https://crrev.com/ee06edf73261ca3c1682abad694a8a357e717a1a
Cr-Commit-Position: refs/heads/master@{#405957}
==========

[commit-bot: I haz the power, 2016-07-17 18:42:53]

Patchset 3 (id:??) landed as
https://crrev.com/ee06edf73261ca3c1682abad694a8a357e717a1a
Cr-Commit-Position: refs/heads/master@{#405957}