Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Issue 2133223004: Convert video-played* tests to testharness.js (Closed)

Created:
4 years, 5 months ago by Srirama
Modified:
4 years, 5 months ago
Reviewers:
fs, foolip
CC:
blink-reviews, chromium-reviews, eric.carlson_apple.com, feature-media-reviews_chromium.org, mlamouri+watch-blink_chromium.org, posciak+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert video-played* tests to testharness.js Cleaning up video-played* tests in media/ to use testharness.js instead of video-test.js. This will enable to upstream these tests to web-platform-tests. BUG=588956 Committed: https://crrev.com/ee06edf73261ca3c1682abad694a8a357e717a1a Cr-Commit-Position: refs/heads/master@{#405957}

Patch Set 1 #

Total comments: 3

Patch Set 2 : address comments #

Total comments: 2

Patch Set 3 : address nit, add TODO #

Unified diffs Side-by-side diffs Delta from patch set Stats (+240 lines, -597 lines) Patch
M third_party/WebKit/LayoutTests/media/video-played.js View 1 2 1 chunk +60 lines, -154 lines 0 comments Download
M third_party/WebKit/LayoutTests/media/video-played-collapse.html View 1 1 chunk +68 lines, -106 lines 0 comments Download
D third_party/WebKit/LayoutTests/media/video-played-collapse-expected.txt View 1 chunk +0 lines, -45 lines 0 comments Download
M third_party/WebKit/LayoutTests/media/video-played-ranges-1.html View 1 1 chunk +58 lines, -101 lines 0 comments Download
D third_party/WebKit/LayoutTests/media/video-played-ranges-1-expected.txt View 1 chunk +0 lines, -62 lines 0 comments Download
M third_party/WebKit/LayoutTests/media/video-played-reset.html View 1 2 1 chunk +54 lines, -91 lines 0 comments Download
D third_party/WebKit/LayoutTests/media/video-played-reset-expected.txt View 1 chunk +0 lines, -38 lines 0 comments Download

Messages

Total messages: 19 (9 generated)
Srirama
PTAL
4 years, 5 months ago (2016-07-09 11:24:13 UTC) #5
fs
https://codereview.chromium.org/2133223004/diff/40001/third_party/WebKit/LayoutTests/media/video-played.js File third_party/WebKit/LayoutTests/media/video-played.js (right): https://codereview.chromium.org/2133223004/diff/40001/third_party/WebKit/LayoutTests/media/video-played.js#newcode1 third_party/WebKit/LayoutTests/media/video-played.js:1: var expectedStartTimes = new Array(); Could we try making ...
4 years, 5 months ago (2016-07-12 18:04:24 UTC) #6
Srirama
https://codereview.chromium.org/2133223004/diff/40001/third_party/WebKit/LayoutTests/media/video-played.js File third_party/WebKit/LayoutTests/media/video-played.js (right): https://codereview.chromium.org/2133223004/diff/40001/third_party/WebKit/LayoutTests/media/video-played.js#newcode1 third_party/WebKit/LayoutTests/media/video-played.js:1: var expectedStartTimes = new Array(); On 2016/07/12 18:04:24, fs ...
4 years, 5 months ago (2016-07-13 18:48:32 UTC) #7
fs
https://codereview.chromium.org/2133223004/diff/40001/third_party/WebKit/LayoutTests/media/video-played.js File third_party/WebKit/LayoutTests/media/video-played.js (right): https://codereview.chromium.org/2133223004/diff/40001/third_party/WebKit/LayoutTests/media/video-played.js#newcode1 third_party/WebKit/LayoutTests/media/video-played.js:1: var expectedStartTimes = new Array(); On 2016/07/13 at 18:48:32, ...
4 years, 5 months ago (2016-07-15 19:36:48 UTC) #8
Srirama
On 2016/07/15 19:36:48, fs (ooo to July 18) wrote: > https://codereview.chromium.org/2133223004/diff/40001/third_party/WebKit/LayoutTests/media/video-played.js > File third_party/WebKit/LayoutTests/media/video-played.js (right): ...
4 years, 5 months ago (2016-07-16 07:12:06 UTC) #9
fs
On 2016/07/16 at 07:12:06, srirama.m wrote: > On 2016/07/15 19:36:48, fs (ooo to July 18) ...
4 years, 5 months ago (2016-07-16 13:28:13 UTC) #10
Srirama
https://codereview.chromium.org/2133223004/diff/60001/third_party/WebKit/LayoutTests/media/video-played-reset.html File third_party/WebKit/LayoutTests/media/video-played-reset.html (right): https://codereview.chromium.org/2133223004/diff/60001/third_party/WebKit/LayoutTests/media/video-played-reset.html#newcode43 third_party/WebKit/LayoutTests/media/video-played-reset.html:43: function ResetToAnEmptyVideoSource() { On 2016/07/16 13:28:13, fs (ooo to ...
4 years, 5 months ago (2016-07-17 17:00:34 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2133223004/100001
4 years, 5 months ago (2016-07-17 17:00:55 UTC) #15
commit-bot: I haz the power
Committed patchset #3 (id:100001)
4 years, 5 months ago (2016-07-17 18:41:43 UTC) #17
commit-bot: I haz the power
4 years, 5 months ago (2016-07-17 18:42:53 UTC) #19
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/ee06edf73261ca3c1682abad694a8a357e717a1a
Cr-Commit-Position: refs/heads/master@{#405957}

Powered by Google App Engine
This is Rietveld 408576698