Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2133223002:
Additional supported languages on Chrome on iOS. (Closed)
DescriptionAdditional supported languages on Chrome on iOS.
iOS system, Chrome itself and all of the third-party libraries
supports those locales, so pack them when building with gn.
BUG=625667
Committed: https://crrev.com/329e5137e45f52d2fcf9c94d6aafbcd9c4bf94d2
Cr-Commit-Position: refs/heads/master@{#405121}
Patch Set 1 #
Messages
Total messages: 25 (12 generated)
Description was changed from ========== Additional supported languages on Chrome on iOS. BUG=625667 ========== to ========== Additional supported languages on Chrome on iOS. iOS system, Chrome itself and all of the third-party libraries supports those locales, so pack them when building with gn. BUG=625667 ==========
sdefresne@chromium.org changed reviewers: + rohitrao@chromium.org
Please take a look and send to CQ if LGTY.
sdefresne@chromium.org changed reviewers: + lpromero@chromium.org - rohitrao@chromium.org
The CQ bit was checked by lpromero@chromium.org
lgtm
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
rohitrao@chromium.org changed reviewers: + rohitrao@chromium.org
lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
sdefresne@chromium.org changed reviewers: + dpranke@chromium.org
dpranke: can you give OWNERS approval?
lgtm
The CQ bit was checked by sdefresne@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by sdefresne@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Additional supported languages on Chrome on iOS. iOS system, Chrome itself and all of the third-party libraries supports those locales, so pack them when building with gn. BUG=625667 ========== to ========== Additional supported languages on Chrome on iOS. iOS system, Chrome itself and all of the third-party libraries supports those locales, so pack them when building with gn. BUG=625667 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Additional supported languages on Chrome on iOS. iOS system, Chrome itself and all of the third-party libraries supports those locales, so pack them when building with gn. BUG=625667 ========== to ========== Additional supported languages on Chrome on iOS. iOS system, Chrome itself and all of the third-party libraries supports those locales, so pack them when building with gn. BUG=625667 Committed: https://crrev.com/329e5137e45f52d2fcf9c94d6aafbcd9c4bf94d2 Cr-Commit-Position: refs/heads/master@{#405121} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/329e5137e45f52d2fcf9c94d6aafbcd9c4bf94d2 Cr-Commit-Position: refs/heads/master@{#405121} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
